From 8dc166f052523af8036ad1c6391376676454764f Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Wed, 7 Aug 2019 12:01:01 -0700 Subject: [PATCH 01/33] add coveralls-maven-plugin for coverage publishing to coveralls.io --- libraries/bot-connector/pom.xml | 8 ++++++++ libraries/botbuilder-schema/pom.xml | 8 ++++++++ libraries/botbuilder/pom.xml | 8 ++++++++ 3 files changed, 24 insertions(+) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index 6470d2da1..55c4045d4 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -145,6 +145,14 @@ 1.8 + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 6fe6dd8e4..1ac8f02d2 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -105,6 +105,14 @@ 1.8 + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index 1306f139d..17a99c0b4 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -162,6 +162,14 @@ + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + From d1f5aabf7ce1509ae0b58ac83bdf432d39c5b1d3 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Wed, 7 Aug 2019 13:17:32 -0700 Subject: [PATCH 02/33] Add cobertura-maven-plugin --- libraries/bot-connector/pom.xml | 12 +++++++++++- libraries/botbuilder-schema/pom.xml | 11 +++++++++++ libraries/botbuilder/pom.xml | 12 +++++++++++- 3 files changed, 33 insertions(+), 2 deletions(-) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index 55c4045d4..6b1f76c9a 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -135,7 +135,6 @@ - org.apache.maven.plugins maven-compiler-plugin @@ -153,6 +152,17 @@ yourcoverallsprojectrepositorytoken + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 1ac8f02d2..c4aab9a36 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -113,6 +113,17 @@ yourcoverallsprojectrepositorytoken + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index 17a99c0b4..a1d3e1580 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -157,7 +157,6 @@ true - @@ -170,6 +169,17 @@ yourcoverallsprojectrepositorytoken + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + From 9f5279fcf312a8866a72c7a5b564f7eb47ce9b80 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Wed, 7 Aug 2019 16:46:39 -0700 Subject: [PATCH 03/33] Add reporting section with cobertura-maven-plugin --- libraries/bot-connector/pom.xml | 15 +++++++++++++++ libraries/botbuilder-schema/pom.xml | 15 +++++++++++++++ libraries/botbuilder/pom.xml | 15 +++++++++++++++ 3 files changed, 45 insertions(+) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index 6b1f76c9a..59d4e8b5f 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -165,6 +165,21 @@ + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index c4aab9a36..345f68ad2 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -126,6 +126,21 @@ + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index a1d3e1580..730217c89 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -182,6 +182,21 @@ + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + From d9351620f3ecf7a9600297c217ebed08fcfdf869 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Wed, 7 Aug 2019 17:01:40 -0700 Subject: [PATCH 04/33] Add cobertura-maven-plugin stuff to sample --- samples/bot-connector-sample/pom.xml | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/samples/bot-connector-sample/pom.xml b/samples/bot-connector-sample/pom.xml index 43fc0e91d..2b716b6bd 100644 --- a/samples/bot-connector-sample/pom.xml +++ b/samples/bot-connector-sample/pom.xml @@ -105,7 +105,41 @@ + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + From 1cf996ea730a5c2b7c2cee991b53bd0aa9f81cfd Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 09:52:15 -0700 Subject: [PATCH 05/33] cobertura plugins moved to the root pom.xml --- libraries/bot-connector/pom.xml | 34 ----------------- libraries/botbuilder-schema/pom.xml | 34 ----------------- libraries/botbuilder/pom.xml | 34 ----------------- pom.xml | 57 ++++++++++++++++++++++++++++ samples/bot-connector-sample/pom.xml | 34 ----------------- 5 files changed, 57 insertions(+), 136 deletions(-) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index 59d4e8b5f..0c979b3d8 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -144,42 +144,8 @@ 1.8 - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 345f68ad2..6fe6dd8e4 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -105,42 +105,8 @@ 1.8 - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index 730217c89..b7f455b9b 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -161,42 +161,8 @@ - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - diff --git a/pom.xml b/pom.xml index 384f02397..a82da551f 100644 --- a/pom.xml +++ b/pom.xml @@ -21,4 +21,61 @@ libraries/bot-connector samples/bot-connector-sample + + + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + + 85 + 85 + true + 85 + 85 + 85 + 85 + + + xml + + true + + + + post-integration-test + + check + cobertura + + + + + + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + + \ No newline at end of file diff --git a/samples/bot-connector-sample/pom.xml b/samples/bot-connector-sample/pom.xml index 2b716b6bd..43fc0e91d 100644 --- a/samples/bot-connector-sample/pom.xml +++ b/samples/bot-connector-sample/pom.xml @@ -105,41 +105,7 @@ - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - From 16d40563437038253bd4d3bc27fa594dd30e5952 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 10:37:16 -0700 Subject: [PATCH 06/33] Plugins added back to the child projects, but without the configuration which is apparently inherited from the parent. --- libraries/bot-connector/pom.xml | 22 ++++++++++++++++++++++ libraries/botbuilder-schema/pom.xml | 22 ++++++++++++++++++++++ libraries/botbuilder/pom.xml | 22 ++++++++++++++++++++++ samples/bot-connector-sample/pom.xml | 22 ++++++++++++++++++++++ 4 files changed, 88 insertions(+) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index 0c979b3d8..d4e734724 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -144,8 +144,30 @@ 1.8 + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + + diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 6fe6dd8e4..7d3f83c4e 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -105,8 +105,30 @@ 1.8 + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + + diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index b7f455b9b..659ff58b6 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -161,8 +161,30 @@ + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + + diff --git a/samples/bot-connector-sample/pom.xml b/samples/bot-connector-sample/pom.xml index 43fc0e91d..117e2bf9f 100644 --- a/samples/bot-connector-sample/pom.xml +++ b/samples/bot-connector-sample/pom.xml @@ -105,7 +105,29 @@ + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + + From 02463566523adf2878951354a20ec2701b382691 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 11:32:10 -0700 Subject: [PATCH 07/33] Revert "Plugins added back to the child projects, but without the configuration which is apparently inherited from the parent." This reverts commit 16d40563437038253bd4d3bc27fa594dd30e5952. Roll everything back to commit d93516 --- libraries/bot-connector/pom.xml | 22 ---------------------- libraries/botbuilder-schema/pom.xml | 22 ---------------------- libraries/botbuilder/pom.xml | 22 ---------------------- samples/bot-connector-sample/pom.xml | 22 ---------------------- 4 files changed, 88 deletions(-) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index d4e734724..0c979b3d8 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -144,30 +144,8 @@ 1.8 - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - - diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 7d3f83c4e..6fe6dd8e4 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -105,30 +105,8 @@ 1.8 - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - - diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index 659ff58b6..b7f455b9b 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -161,30 +161,8 @@ - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - - diff --git a/samples/bot-connector-sample/pom.xml b/samples/bot-connector-sample/pom.xml index 117e2bf9f..43fc0e91d 100644 --- a/samples/bot-connector-sample/pom.xml +++ b/samples/bot-connector-sample/pom.xml @@ -105,29 +105,7 @@ - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - - From 04cfe8011884da030f0d5e7a409a109270986e7c Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 11:37:26 -0700 Subject: [PATCH 08/33] Revert "cobertura plugins moved to the root pom.xml" This reverts commit 1cf996ea730a5c2b7c2cee991b53bd0aa9f81cfd. Revert back to yesterday's last commit --- libraries/bot-connector/pom.xml | 34 +++++++++++++++++ libraries/botbuilder-schema/pom.xml | 34 +++++++++++++++++ libraries/botbuilder/pom.xml | 34 +++++++++++++++++ pom.xml | 57 ---------------------------- samples/bot-connector-sample/pom.xml | 34 +++++++++++++++++ 5 files changed, 136 insertions(+), 57 deletions(-) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index 0c979b3d8..59d4e8b5f 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -144,8 +144,42 @@ 1.8 + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 6fe6dd8e4..345f68ad2 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -105,8 +105,42 @@ 1.8 + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index b7f455b9b..730217c89 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -161,8 +161,42 @@ + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + diff --git a/pom.xml b/pom.xml index a82da551f..384f02397 100644 --- a/pom.xml +++ b/pom.xml @@ -21,61 +21,4 @@ libraries/bot-connector samples/bot-connector-sample - - - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - - 85 - 85 - true - 85 - 85 - 85 - 85 - - - xml - - true - - - - post-integration-test - - check - cobertura - - - - - - - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - - \ No newline at end of file diff --git a/samples/bot-connector-sample/pom.xml b/samples/bot-connector-sample/pom.xml index 43fc0e91d..2b716b6bd 100644 --- a/samples/bot-connector-sample/pom.xml +++ b/samples/bot-connector-sample/pom.xml @@ -105,7 +105,41 @@ + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + xml + 256m + + true + + + + From bbb7f216c59b0e02927a6af23df8c0bfd30dde1b Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 11:43:37 -0700 Subject: [PATCH 09/33] Add cobertura-maven-plugin back to rot pom.xml, including outputDirectory and aggregate settings. --- pom.xml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/pom.xml b/pom.xml index 384f02397..ec38fb37b 100644 --- a/pom.xml +++ b/pom.xml @@ -21,4 +21,22 @@ libraries/bot-connector samples/bot-connector-sample + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + ./target/tmpCobertura + + xml + + true + + + + + \ No newline at end of file From 68ecd177770bf845807771996eb8416eeaf520c0 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 12:15:04 -0700 Subject: [PATCH 10/33] Add ../../cobertura-report to reporting --- libraries/bot-connector/pom.xml | 3 ++- libraries/botbuilder-schema/pom.xml | 1 + libraries/botbuilder/pom.xml | 3 ++- samples/bot-connector-sample/pom.xml | 1 + 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index 59d4e8b5f..c482d5704 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -172,7 +172,8 @@ cobertura-maven-plugin 2.7 - xml + ../../cobertura-report + xml 256m true diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 345f68ad2..15583dc5f 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -133,6 +133,7 @@ cobertura-maven-plugin 2.7 + ../../cobertura-report xml 256m diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index 730217c89..16d6725ae 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -189,7 +189,8 @@ cobertura-maven-plugin 2.7 - xml + ../../cobertura-report + xml 256m true diff --git a/samples/bot-connector-sample/pom.xml b/samples/bot-connector-sample/pom.xml index 2b716b6bd..f050a9bc1 100644 --- a/samples/bot-connector-sample/pom.xml +++ b/samples/bot-connector-sample/pom.xml @@ -118,6 +118,7 @@ cobertura-maven-plugin 2.7 + ../../cobertura-report xml 256m From 3ab124b2ef685ad1d3d8b46c6db97213305914a5 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 12:41:43 -0700 Subject: [PATCH 11/33] Add separate subfolders to outputDirectory --- libraries/bot-connector/pom.xml | 2 +- libraries/botbuilder-schema/pom.xml | 2 +- libraries/botbuilder/pom.xml | 2 +- samples/bot-connector-sample/pom.xml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index c482d5704..e1fe12cb3 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -172,7 +172,7 @@ cobertura-maven-plugin 2.7 - ../../cobertura-report + ../../cobertura-report/bot-connector xml 256m diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 15583dc5f..1c0ed0b47 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -133,7 +133,7 @@ cobertura-maven-plugin 2.7 - ../../cobertura-report + ../../cobertura-report/botbuilder-schema xml 256m diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index 16d6725ae..fae83c30e 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -189,7 +189,7 @@ cobertura-maven-plugin 2.7 - ../../cobertura-report + ../../cobertura-report/botbuilder xml 256m diff --git a/samples/bot-connector-sample/pom.xml b/samples/bot-connector-sample/pom.xml index f050a9bc1..cc8a7237b 100644 --- a/samples/bot-connector-sample/pom.xml +++ b/samples/bot-connector-sample/pom.xml @@ -118,7 +118,7 @@ cobertura-maven-plugin 2.7 - ../../cobertura-report + ../../cobertura-report/bot-connector-sample xml 256m From e0eb4db3df8208edc36df9bc783725adac0eaa0a Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 13:21:39 -0700 Subject: [PATCH 12/33] Move outputDirectory spec to build plugin from reporting plugin --- libraries/bot-connector/pom.xml | 2 +- libraries/botbuilder-schema/pom.xml | 2 +- libraries/botbuilder/pom.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index e1fe12cb3..5a0460a39 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -157,6 +157,7 @@ cobertura-maven-plugin 2.7 + ../../cobertura-report/bot-connector xml 256m @@ -172,7 +173,6 @@ cobertura-maven-plugin 2.7 - ../../cobertura-report/bot-connector xml 256m diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 1c0ed0b47..515bc2b3b 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -118,6 +118,7 @@ cobertura-maven-plugin 2.7 + ../../cobertura-report/botbuilder-schema xml 256m @@ -133,7 +134,6 @@ cobertura-maven-plugin 2.7 - ../../cobertura-report/botbuilder-schema xml 256m diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index fae83c30e..1e63e0f5c 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -174,6 +174,7 @@ cobertura-maven-plugin 2.7 + ../../cobertura-report/botbuilder xml 256m @@ -189,7 +190,6 @@ cobertura-maven-plugin 2.7 - ../../cobertura-report/botbuilder xml 256m From db0d1d111bda994909a8577a9640ad26e98cde54 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 13:44:17 -0700 Subject: [PATCH 13/33] Add coveralls-maven-plugin to parent pom --- pom.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pom.xml b/pom.xml index ec38fb37b..c0dafe944 100644 --- a/pom.xml +++ b/pom.xml @@ -24,6 +24,15 @@ + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + + org.codehaus.mojo cobertura-maven-plugin From 08045a76a2e34087627c0a1006a7858e047ccb78 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 13:51:05 -0700 Subject: [PATCH 14/33] Add coveralls-maven-plugin to build section of root pom --- pom.xml | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index c0dafe944..fe90b84da 100644 --- a/pom.xml +++ b/pom.xml @@ -21,7 +21,33 @@ libraries/bot-connector samples/bot-connector-sample - + + + + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + + ./target/tmpCobertura + + xml + + true + + + + + From 1bf5b85fbb2462aaa4c5da9056eb8efbd76eeab0 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 13:59:57 -0700 Subject: [PATCH 15/33] Add UTF-8 to root pom --- pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/pom.xml b/pom.xml index fe90b84da..d4937b475 100644 --- a/pom.xml +++ b/pom.xml @@ -12,6 +12,7 @@ https://github.com/Microsoft/botbuilder-java + UTF-8 true From 9d48af6020aeb1ef04e9d3f8acf342e837c10781 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 14:11:43 -0700 Subject: [PATCH 16/33] Add to root pom: ./cobertura-report --- pom.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index d4937b475..d249135a8 100644 --- a/pom.xml +++ b/pom.xml @@ -56,6 +56,7 @@ coveralls-maven-plugin 4.3.0 + ./cobertura-report yourcoverallsprojectrepositorytoken @@ -65,7 +66,7 @@ cobertura-maven-plugin 2.7 - ./target/tmpCobertura + ./cobertura-report xml From 8edcd75d396fa30ddb214118591a332b28c19fca Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 14:22:43 -0700 Subject: [PATCH 17/33] Remove reporting section from root pom --- pom.xml | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/pom.xml b/pom.xml index d249135a8..747b30a23 100644 --- a/pom.xml +++ b/pom.xml @@ -48,32 +48,5 @@ - - - - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - ./cobertura-report - yourcoverallsprojectrepositorytoken - - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - ./cobertura-report - - xml - - true - - - - \ No newline at end of file From 53f0d8d6e7a45d95f61a111f2c69d2a5386e626a Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 14:32:51 -0700 Subject: [PATCH 18/33] Fix incorrect outputDirectory in root pom --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 747b30a23..09fb7998b 100644 --- a/pom.xml +++ b/pom.xml @@ -39,7 +39,7 @@ cobertura-maven-plugin 2.7 - ./target/tmpCobertura + ./cobertura-report xml From 5296c745b2965ff6f691ac1a816a0978082eda1d Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 14:43:20 -0700 Subject: [PATCH 19/33] Add configuration parameter coberturaReports to root pom cobertura-maven-plugin --- pom.xml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 09fb7998b..624ca2b12 100644 --- a/pom.xml +++ b/pom.xml @@ -39,7 +39,12 @@ cobertura-maven-plugin 2.7 - ./cobertura-report + + ./cobertura-report/botbuilder/coverage.xml, + ./cobertura-report/botbuilder-schema/coverage.xml, + ./cobertura-report/bot-connector/coverage.xml, + ./cobertura-report/bot-connector-sample/coverage.xml + xml From d863a70230ea53cf1b15060c39a1108f579ff2fe Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 15:07:14 -0700 Subject: [PATCH 20/33] Change format of coberturaReports list --- pom.xml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/pom.xml b/pom.xml index 624ca2b12..143396e97 100644 --- a/pom.xml +++ b/pom.xml @@ -39,12 +39,7 @@ cobertura-maven-plugin 2.7 - - ./cobertura-report/botbuilder/coverage.xml, - ./cobertura-report/botbuilder-schema/coverage.xml, - ./cobertura-report/bot-connector/coverage.xml, - ./cobertura-report/bot-connector-sample/coverage.xml - + ./cobertura-report/botbuilder/coverage.xml,./cobertura-report/botbuilder-schema/coverage.xml,./cobertura-report/bot-connector/coverage.xml,./cobertura-report/bot-connector-sample/coverage.xml xml From d9249fc2ea2437a41d5f7dd01f4f8cb101cc1477 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 15:16:57 -0700 Subject: [PATCH 21/33] Fix coberturaReports list format --- pom.xml | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 143396e97..2892b325f 100644 --- a/pom.xml +++ b/pom.xml @@ -39,7 +39,21 @@ cobertura-maven-plugin 2.7 - ./cobertura-report/botbuilder/coverage.xml,./cobertura-report/botbuilder-schema/coverage.xml,./cobertura-report/bot-connector/coverage.xml,./cobertura-report/bot-connector-sample/coverage.xml + + + ./cobertura-report/botbuilder/coverage.xml + + + ./cobertura-report/botbuilder-schema/coverage.xml + + + ./cobertura-report/bot-connector/coverage.xml + + + ./cobertura-report/bot-connector-sample/coverage.xml + + + xml From 87600e3428ef33b86eac09b826b99e81497a5265 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 15:27:50 -0700 Subject: [PATCH 22/33] Strip coberturaReports, outputDirectory entries from all poms --- libraries/bot-connector/pom.xml | 1 - libraries/botbuilder-schema/pom.xml | 1 - libraries/botbuilder/pom.xml | 1 - pom.xml | 15 --------------- samples/bot-connector-sample/pom.xml | 1 - 5 files changed, 19 deletions(-) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index 5a0460a39..1718e6226 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -157,7 +157,6 @@ cobertura-maven-plugin 2.7 - ../../cobertura-report/bot-connector xml 256m diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 515bc2b3b..345f68ad2 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -118,7 +118,6 @@ cobertura-maven-plugin 2.7 - ../../cobertura-report/botbuilder-schema xml 256m diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index 1e63e0f5c..7c60ec0a3 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -174,7 +174,6 @@ cobertura-maven-plugin 2.7 - ../../cobertura-report/botbuilder xml 256m diff --git a/pom.xml b/pom.xml index 2892b325f..dd9a400ac 100644 --- a/pom.xml +++ b/pom.xml @@ -39,21 +39,6 @@ cobertura-maven-plugin 2.7 - - - ./cobertura-report/botbuilder/coverage.xml - - - ./cobertura-report/botbuilder-schema/coverage.xml - - - ./cobertura-report/bot-connector/coverage.xml - - - ./cobertura-report/bot-connector-sample/coverage.xml - - - xml diff --git a/samples/bot-connector-sample/pom.xml b/samples/bot-connector-sample/pom.xml index cc8a7237b..2b716b6bd 100644 --- a/samples/bot-connector-sample/pom.xml +++ b/samples/bot-connector-sample/pom.xml @@ -118,7 +118,6 @@ cobertura-maven-plugin 2.7 - ../../cobertura-report/bot-connector-sample xml 256m From 779fadb7d794c8e6c6bf33e57898d45683d0a75d Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 15:32:48 -0700 Subject: [PATCH 23/33] Revert "Strip coberturaReports, outputDirectory entries from all poms" This reverts commit 87600e3428ef33b86eac09b826b99e81497a5265. Revert last commit --- libraries/bot-connector/pom.xml | 1 + libraries/botbuilder-schema/pom.xml | 1 + libraries/botbuilder/pom.xml | 1 + pom.xml | 15 +++++++++++++++ samples/bot-connector-sample/pom.xml | 1 + 5 files changed, 19 insertions(+) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index 1718e6226..5a0460a39 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -157,6 +157,7 @@ cobertura-maven-plugin 2.7 + ../../cobertura-report/bot-connector xml 256m diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 345f68ad2..515bc2b3b 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -118,6 +118,7 @@ cobertura-maven-plugin 2.7 + ../../cobertura-report/botbuilder-schema xml 256m diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index 7c60ec0a3..1e63e0f5c 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -174,6 +174,7 @@ cobertura-maven-plugin 2.7 + ../../cobertura-report/botbuilder xml 256m diff --git a/pom.xml b/pom.xml index dd9a400ac..2892b325f 100644 --- a/pom.xml +++ b/pom.xml @@ -39,6 +39,21 @@ cobertura-maven-plugin 2.7 + + + ./cobertura-report/botbuilder/coverage.xml + + + ./cobertura-report/botbuilder-schema/coverage.xml + + + ./cobertura-report/bot-connector/coverage.xml + + + ./cobertura-report/bot-connector-sample/coverage.xml + + + xml diff --git a/samples/bot-connector-sample/pom.xml b/samples/bot-connector-sample/pom.xml index 2b716b6bd..cc8a7237b 100644 --- a/samples/bot-connector-sample/pom.xml +++ b/samples/bot-connector-sample/pom.xml @@ -118,6 +118,7 @@ cobertura-maven-plugin 2.7 + ../../cobertura-report/bot-connector-sample xml 256m From f187267c219c94f8022352e7d7f5211d258014c5 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 15:34:58 -0700 Subject: [PATCH 24/33] Revert the last stripping, move coverturaReports section to coveralls-maven-plugin where it belongs. --- pom.xml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/pom.xml b/pom.xml index 2892b325f..043f14cee 100644 --- a/pom.xml +++ b/pom.xml @@ -29,15 +29,6 @@ org.eluder.coveralls coveralls-maven-plugin 4.3.0 - - yourcoverallsprojectrepositorytoken - - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 @@ -53,7 +44,16 @@ ./cobertura-report/bot-connector-sample/coverage.xml - + + yourcoverallsprojectrepositorytoken + + + + + org.codehaus.mojo + cobertura-maven-plugin + 2.7 + xml From d19a175c630c967eadcdf1a76f0a1b1e52f3cc74 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 15:52:32 -0700 Subject: [PATCH 25/33] Add serviceJobId to coveralls-maven-plugin --- pom.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pom.xml b/pom.xml index 043f14cee..cfb59ce2d 100644 --- a/pom.xml +++ b/pom.xml @@ -45,6 +45,9 @@ + UTF-8 + azure-ci + ${env.TRAVIS_JOB_ID} yourcoverallsprojectrepositorytoken From f18f1070ead3dffdcf80ef22ccaa86c932dbcc5a Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 16:22:42 -0700 Subject: [PATCH 26/33] Changed to ${env.COVERALLS_SERVICE_JOB_ID} --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index cfb59ce2d..e31033dff 100644 --- a/pom.xml +++ b/pom.xml @@ -46,8 +46,8 @@ UTF-8 - azure-ci - ${env.TRAVIS_JOB_ID} + ${env.COVERALLS_SERVICE_NAME} + ${env.COVERALLS_SERVICE_JOB_ID} yourcoverallsprojectrepositorytoken From 823847c676b7dbb0fa348a308297ae375f5141ef Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 16:33:35 -0700 Subject: [PATCH 27/33] Remove repoToken setting from plugin --- pom.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/pom.xml b/pom.xml index e31033dff..fc302a265 100644 --- a/pom.xml +++ b/pom.xml @@ -48,7 +48,6 @@ UTF-8 ${env.COVERALLS_SERVICE_NAME} ${env.COVERALLS_SERVICE_JOB_ID} - yourcoverallsprojectrepositorytoken From 568a018d16921db7dcd14e93cee435a0c4061884 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 16:54:33 -0700 Subject: [PATCH 28/33] Populate more coveralls variables. --- pom.xml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index fc302a265..5026788ab 100644 --- a/pom.xml +++ b/pom.xml @@ -46,8 +46,11 @@ UTF-8 - ${env.COVERALLS_SERVICE_NAME} + ${env.COVERALLS_PULL_REQUEST} + ${env.COVERALLS_SERVICE_BUILD_NUMBER} + ${env.COVERALLS_SERVICE_BUILD_URL} ${env.COVERALLS_SERVICE_JOB_ID} + ${env.COVERALLS_SERVICE_NAME} From faf146d07883f9d8247ad3193d73397599ea899e Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 17:13:11 -0700 Subject: [PATCH 29/33] Add branch --- pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/pom.xml b/pom.xml index 5026788ab..8fbc7e672 100644 --- a/pom.xml +++ b/pom.xml @@ -46,6 +46,7 @@ UTF-8 + ${env.COVERALLS_GIT_BRANCH} ${env.COVERALLS_PULL_REQUEST} ${env.COVERALLS_SERVICE_BUILD_NUMBER} ${env.COVERALLS_SERVICE_BUILD_URL} From a35b20584a446a63a9774dcfeabe819e8a4aafc0 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 17:27:42 -0700 Subject: [PATCH 30/33] Remove reporting sections from pom files --- libraries/bot-connector/pom.xml | 16 +--------------- libraries/botbuilder-schema/pom.xml | 16 +--------------- libraries/botbuilder/pom.xml | 16 ---------------- samples/bot-connector-sample/pom.xml | 16 +--------------- 4 files changed, 3 insertions(+), 61 deletions(-) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index 5a0460a39..ef7f3678c 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -166,21 +166,7 @@ - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - + diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 515bc2b3b..6db2120a2 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -127,21 +127,7 @@ - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - + diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index 1e63e0f5c..b2609815d 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -183,22 +183,6 @@ - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - - publish diff --git a/samples/bot-connector-sample/pom.xml b/samples/bot-connector-sample/pom.xml index cc8a7237b..6b9d9f2f3 100644 --- a/samples/bot-connector-sample/pom.xml +++ b/samples/bot-connector-sample/pom.xml @@ -128,19 +128,5 @@ - - - - org.codehaus.mojo - cobertura-maven-plugin - 2.7 - - xml - 256m - - true - - - - + From ad7ed4b33f1bce57bce08fcf1ec5a9ba96d74f0f Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 17:30:53 -0700 Subject: [PATCH 31/33] Fix broken pom.xml --- libraries/botbuilder/pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index b2609815d..3bd67b922 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -183,6 +183,7 @@ + publish From f88f75be51bb3c0af052f417cb18a06c05844b8c Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 17:43:36 -0700 Subject: [PATCH 32/33] Remove coveralls-maven-plugin from child project poms --- libraries/bot-connector/pom.xml | 8 -------- libraries/botbuilder-schema/pom.xml | 8 -------- libraries/botbuilder/pom.xml | 8 -------- samples/bot-connector-sample/pom.xml | 8 -------- 4 files changed, 32 deletions(-) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index ef7f3678c..2b525616c 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -144,14 +144,6 @@ 1.8 - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - org.codehaus.mojo cobertura-maven-plugin diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index 6db2120a2..b0cc94c4f 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -105,14 +105,6 @@ 1.8 - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - org.codehaus.mojo cobertura-maven-plugin diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index 3bd67b922..30a645ed8 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -161,14 +161,6 @@ - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - org.codehaus.mojo cobertura-maven-plugin diff --git a/samples/bot-connector-sample/pom.xml b/samples/bot-connector-sample/pom.xml index 6b9d9f2f3..abbbd50c4 100644 --- a/samples/bot-connector-sample/pom.xml +++ b/samples/bot-connector-sample/pom.xml @@ -105,14 +105,6 @@ - - org.eluder.coveralls - coveralls-maven-plugin - 4.3.0 - - yourcoverallsprojectrepositorytoken - - org.codehaus.mojo cobertura-maven-plugin From d4cfe0c6de9d2fd69513fce6cc7294ce9668d283 Mon Sep 17 00:00:00 2001 From: LocalizationBuildProcess Date: Thu, 8 Aug 2019 17:50:03 -0700 Subject: [PATCH 33/33] Revert "Remove coveralls-maven-plugin from child project poms" This reverts commit f88f75be51bb3c0af052f417cb18a06c05844b8c. --- libraries/bot-connector/pom.xml | 8 ++++++++ libraries/botbuilder-schema/pom.xml | 8 ++++++++ libraries/botbuilder/pom.xml | 8 ++++++++ samples/bot-connector-sample/pom.xml | 8 ++++++++ 4 files changed, 32 insertions(+) diff --git a/libraries/bot-connector/pom.xml b/libraries/bot-connector/pom.xml index 2b525616c..ef7f3678c 100644 --- a/libraries/bot-connector/pom.xml +++ b/libraries/bot-connector/pom.xml @@ -144,6 +144,14 @@ 1.8 + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + org.codehaus.mojo cobertura-maven-plugin diff --git a/libraries/botbuilder-schema/pom.xml b/libraries/botbuilder-schema/pom.xml index b0cc94c4f..6db2120a2 100644 --- a/libraries/botbuilder-schema/pom.xml +++ b/libraries/botbuilder-schema/pom.xml @@ -105,6 +105,14 @@ 1.8 + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + org.codehaus.mojo cobertura-maven-plugin diff --git a/libraries/botbuilder/pom.xml b/libraries/botbuilder/pom.xml index 30a645ed8..3bd67b922 100644 --- a/libraries/botbuilder/pom.xml +++ b/libraries/botbuilder/pom.xml @@ -161,6 +161,14 @@ + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + org.codehaus.mojo cobertura-maven-plugin diff --git a/samples/bot-connector-sample/pom.xml b/samples/bot-connector-sample/pom.xml index abbbd50c4..6b9d9f2f3 100644 --- a/samples/bot-connector-sample/pom.xml +++ b/samples/bot-connector-sample/pom.xml @@ -105,6 +105,14 @@ + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + yourcoverallsprojectrepositorytoken + + org.codehaus.mojo cobertura-maven-plugin