Added servlet-echo and spring-echo sample bots. #94
Conversation
| </dependency> | ||
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-api</artifactId> |
There was a problem hiding this comment.
slf4j-api< [](start = 24, length = 10)
Random q: Is this being pulled in because of autorest? I think this was the library that indirectly pulls in a strange version log4j that I was mentioning earlier..
There was a problem hiding this comment.
While you don't see it in this version, I took a different strategy in an upcoming PR where I deal with dependencies and logging. Since MS Rest is using slf4j, and slf4j is a reasonable solution to the plethora of Java logging libraries, I removed log4j from the core and just use slf4j. This moves the dependency issue out of our core SDK and into the bot. slf4j-api doesn't have any dependencies, but slf4j-log4j12 does pull in the 1.2.x version of log4j, instead of the latest 2.x. My understanding is that there are newer bindings for the Log4j 2 as there are differences between the 1.2.x version and the 2.x versions.
There was a problem hiding this comment.
Got it! I just recall being locked into an older version of log4j somehow. Makes sense!
samples/spring-echo/src/main/java/com/microsoft/bot/sample/spring/Application.java
Show resolved
Hide resolved
daveta
left a comment
daveta
left a comment
There was a problem hiding this comment.
Very nice! It looks great!
Added two new ConnectorClient echo bots that use either Spring Boot or Tomcat as the webapp container. Both bots use the Azure CLI and Azure WebApp Maven plugin to deploy to Azure.
As a side note: The ARM templates in these samples have been enhanced slightly from ones in the other platforms to reduce the number of required command line arguments. The purpose of the samples is to get a bot deployed and running, not to understand all the various Azure options. Primarily, it will use the resource group location as a default instead of requiring the user to specify one for the bot and service plan. If no service plan name (and location) is specified, a default one is created.
Both samples contain complete instructions for deployment in the Readme.