This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Improved dependency management #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 15, 2019 08:23
…POM, and switched to slf4j for core sdk.
daveta
reviewed
Aug 16, 2019
| MicrosoftAppId= | ||
| MicrosoftAppPassword= | ||
| MicrosoftAppId=9c286e2f-e070-4af5-a3f1-350d666214ed | ||
| MicrosoftAppPassword=b0tframew0rk s3cr3t! |
Contributor
There was a problem hiding this comment.
This password value is a bit confusing because it looks a bit like a real password. Suggest making it more obvious by leaving it blank. Or letting the value instruct, as in "insert_botframework_secret_here".
BruceHaley
suggested changes
Aug 16, 2019
| MicrosoftAppId= | ||
| MicrosoftAppPassword= | ||
| MicrosoftAppId=9c286e2f-e070-4af5-a3f1-350d666214ed | ||
| MicrosoftAppPassword=b0tframew0rk s3cr3t! |
Contributor
There was a problem hiding this comment.
This password value is a bit confusing because it looks a bit like a real password. Suggest making it more obvious by leaving it blank. Or letting the value instruct, as in "insert_botframework_secret_here".
BruceHaley
approved these changes
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the dependencyManagement and pluginManagement facility in the parent POM to specify project dependencies. This eliminates having to specify dependency and plugin versions in every POM. I did not utilize this for the samples as I would expect those eventually will be pulled out of the core SDK (as in the other platforms), and will be stand alone Maven projects at some point.
Also moved use of log4j out of the core in preference to using slf4j. slf4j is a lib that abstract various logging libs so that we don't have to care which one the customer will want to use.
Also added CheckStyle to the build. It set to NOT fail for violation at this point (there are too many minor style changes required to comply). This will change in the future.
Ultimately, this will mean we can eventually remove the PMD and CheckStyle steps in the DevOps build as the project will already perform them during the build phase.