Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove antlr auto build with build/test script #2259

Merged
merged 3 commits into from
May 21, 2020

Conversation

Danieladu
Copy link
Contributor

We added antlr4ts-cli into dependency and would auto build g4 grammar when build and test script is executed. But antlr4ts-cli script depends on JAVA environment. the reference is here:
https://www.npmjs.com/package/antlr4ts-cli

So, remove the auto build of antlr, and instead, keep the antlr script, user can still run the script manually with local JAVA environment.

@coveralls
Copy link

coveralls commented May 20, 2020

Pull Request Test Coverage Report for Build 132831

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.286%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 132665: -0.07%
Covered Lines: 12691
Relevant Lines: 15092

💛 - Coveralls

@Danieladu Danieladu merged commit ade38d6 into master May 21, 2020
@Danieladu Danieladu deleted the hond/remove-auto-build branch May 21, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants