Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT]Add sentenceCase && titleCase builtin function #2286

Merged
merged 1 commit into from
May 29, 2020

Conversation

Danieladu
Copy link
Contributor

Fixes #2285

  • Add sentenceCase function
    capitalize first letter of the first word and use lowercase for everything else.
    for example:
 sentenceCase('') -> '' 
 sentenceCase('a')  -> 'A'
 sentenceCase('abc') -> 'Abc'
 sentenceCase('aBC') -> 'Abc'
  • Add titleCase funtion
    Capitalize first letter of each word and use lowercase for everything else.
    for example:
 titleCase('') -> '' 
 titleCase('a')  -> 'A'
 titleCase('abc def') -> 'Abc Def'
 titleCase('aBC') -> 'Abc'

@coveralls
Copy link

coveralls commented May 29, 2020

Pull Request Test Coverage Report for Build 134480

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 80.281%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/adaptive-expressions/src/expressionFunctions.ts 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 134023: -0.08%
Covered Lines: 12700
Relevant Lines: 15103

💛 - Coveralls

@Danieladu Danieladu merged commit 795cab4 into master May 29, 2020
@Danieladu Danieladu deleted the hond/sentenseCase branch May 29, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] Add sentenceCase && titleCase builtin function
3 participants