Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] Added support for declarative custom dialogs #2542

Merged
merged 5 commits into from
Jul 24, 2020
Merged

[PORT] Added support for declarative custom dialogs #2542

merged 5 commits into from
Jul 24, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Jul 16, 2020

Fixes #1961

Description

Supported declarative custom dialogs.

Specific Changes

  • Added DynamicBeginDialog
  • Registered DynamicBeginDialog with custom dialog types
  • Added CustomDialogTypeBuilder to build custom dialog types

Testing

Added test for DynamicBeginDialog

@chon219 chon219 requested a review from a team as a code owner July 16, 2020 07:56
@chon219 chon219 self-assigned this Jul 16, 2020
@chon219 chon219 requested a review from luhan2017 July 16, 2020 07:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 147133

  • 18 of 18 (100.0%) changed or added relevant lines in 4 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 81.048%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 147026: -0.06%
Covered Lines: 13286
Relevant Lines: 15633
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 16, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 149838

  • 18 of 18 (100.0%) changed or added relevant lines in 4 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 81.551%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 149640: -0.06%
Covered Lines: 13430
Relevant Lines: 15702
💛 - Coveralls

Stevenic
Stevenic approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Stevenic Stevenic merged commit 1117b48 into master Jul 24, 2020
@Stevenic Stevenic deleted the zim/custom-dialogs branch July 24, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stevenic Stevenic Stevenic approved these changes

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees

@chon219 chon219

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] [DCR] Add support for declarative custom dialogs
4 participants
@chon219 @coveralls @Stevenic @luhan2017