Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding unit test for custom entity strip checking #2665

Merged
merged 4 commits into from
Aug 6, 2020
Merged

Adding unit test for custom entity strip checking #2665

merged 4 commits into from
Aug 6, 2020

Conversation

Virtual-Josh
Copy link
Contributor

@Virtual-Josh Virtual-Josh commented Aug 6, 2020 •
edited
Loading

Fixes #2649

@Virtual-Josh Virtual-Josh added the R10 Release 10 - August 17th, 2020 label Aug 6, 2020
@coveralls
Copy link

coveralls commented Aug 6, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 154805

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 82.847%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 154766: -0.07%
Covered Lines: 14826
Relevant Lines: 17010
💛 - Coveralls

@axelsrz axelsrz merged commit d60a696 into master Aug 6, 2020
@axelsrz axelsrz deleted the josh/entityUnit branch August 6, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelsrz axelsrz axelsrz approved these changes

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

@johnataylor johnataylor Awaiting requested review from johnataylor

Assignees
No one assigned
Labels
R10 Release 10 - August 17th, 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit test verifying custom properties on activity.entities are not stripped by ms-rest-js
3 participants
@Virtual-Josh @coveralls @axelsrz