-
Notifications
You must be signed in to change notification settings - Fork 306
Closed
Labels
ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.Use this label to exclude the issue from the DRI report.needs-triageThe issue has just been created and it has not been reviewed by the team.The issue has just been created and it has not been reviewed by the team.parityThe issue describes a gap in parity between two or more platforms.The issue describes a gap in parity between two or more platforms.
Description
The changes in (dotnet) Remove comments pertaining to auto-generation in Schema and Connector (#5002) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.
Fixes #4946 Partially fixes [bf-sdk issue#5887](https://github.com/microsoft/botframework-sdk/issues/5887)Description
Files in
Microsoft.Bot.ConnectorandMicrosoft.Bot.Schemaare no longer auto-generated from Swagger, however most files still contain// <auto-generated>comments. This PR:
- Removes "auto-generated" comments in Connector and Schema
- Replace comment with standard Copyright header
// Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License.- Removes misleading
Generatedfolder inMicrosoft.Bot.Schema/Teams/
- Files in this subfolder moved to be under
Teams/folder directly
Update: This PR also corrects 1800+ styling errors that were hidden previously when the files were considered "auto-generated", but now had unearthed themselves for a great big surprise Christmas present to me 😵 ✨ 🎉 😅 🎁
Please review and, if necessary, port the changes.
Metadata
Metadata
Assignees
Labels
ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.Use this label to exclude the issue from the DRI report.needs-triageThe issue has just been created and it has not been reviewed by the team.The issue has just been created and it has not been reviewed by the team.parityThe issue describes a gap in parity between two or more platforms.The issue describes a gap in parity between two or more platforms.