DialogContext.cancel_all_dialogs(True) does not propagate cancellation through parent dialogs

[cas--]

Version

4.13.0

Describe the bug

Within a child dialog we should be able to cancel_all_dialogs by setting the first parameter (cancel_parents) to True and that propagates up through the parents thus cancelling the conversation.

However due to the following statement in dialog_context.py#L224 this does not happen and instead the parent dialog's next step is run.

if cancel_parents is None:

To Reproduce

Steps to reproduce the behavior:

1. In parent dialog MainDialog call begin_dialog('ChildDialog')
2. In ChildDialog waterfall step call step.cancel_all_dialogs(True)

Expected behavior

All dialogs/conversation are ended

Additional Notes

botbuilder-js dialogContext.cancelAllDialogs

[johnataylor]

@axelsrz could you take a look

[axelsrz]

Hello @cas-- , thanks for reporting this issue, we will schedule a fix for our next release.