Only reassign waterfall step name only if the step doesn't have a name #1431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #670
Description
In
WaterfallDialog.get_step_namemethod, it uses__qualname__dunder method to get a unique name for the waterfall stepThe method's intention is to only create and assign a name if the waterfall step is anonymous, which commonplace in C# and JS SDKs.
However, because the full qualname is given, "
>" is present, even if waterfall steps defined with a name (i.e. no anonymous methods used to define steps). This results in an overapplication of renaming waterfall step names, even if the step already has a name to begin with.Click to see more detailed example
Create a waterfall dialog that has one step, which is defined by a function named get_user_name.
Expected Step Name from
get_step_name<full_qualname_prefix>+
.get_user_nameActual Name from
get_step_nameStep1of1Specific Changes
step_nameis not present or if ends with<lambda>Testing