From d1fadb8fa965eff73a1d7ad422530f486ef71968 Mon Sep 17 00:00:00 2001 From: tracyboehrer Date: Tue, 2 Feb 2021 13:34:02 -0600 Subject: [PATCH] pylance warnings corrections for List arguments --- .../botbuilder/adapters/slack/slack_client.py | 14 +++++++------- .../botbuilder/adapters/slack/slack_event.py | 3 ++- .../botbuilder/adapters/slack/slack_payload.py | 2 +- .../adapters/slack/slack_request_body.py | 3 ++- .../botbuilder/ai/qna/utils/qna_card_builder.py | 3 ++- .../botbuilder/schema/health_results.py | 3 ++- 6 files changed, 16 insertions(+), 12 deletions(-) diff --git a/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_client.py b/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_client.py index 0911ce965..297fb6b8e 100644 --- a/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_client.py +++ b/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_client.py @@ -5,7 +5,7 @@ import hmac import json from io import IOBase -from typing import Union +from typing import List, Union import aiohttp from aiohttp.web_request import Request @@ -116,7 +116,7 @@ async def files_list_ex( date_to: str = None, count: int = None, page: int = None, - types: [str] = None, + types: List[str] = None, ) -> SlackResponse: args = {} @@ -185,7 +185,7 @@ async def chat_post_ephemeral_ex( target_user: str, parse: str = None, link_names: bool = False, - attachments: [str] = None, # pylint: disable=unused-argument + attachments: List[str] = None, # pylint: disable=unused-argument as_user: bool = False, ) -> SlackResponse: args = { @@ -210,8 +210,8 @@ async def chat_post_message_ex( bot_name: str = None, parse: str = None, link_names: bool = False, - blocks: [str] = None, # pylint: disable=unused-argument - attachments: [str] = None, # pylint: disable=unused-argument + blocks: List[str] = None, # pylint: disable=unused-argument + attachments: List[str] = None, # pylint: disable=unused-argument unfurl_links: bool = False, icon_url: str = None, icon_emoji: str = None, @@ -328,7 +328,7 @@ async def chat_update_ex( bot_name: str = None, parse: str = None, link_names: bool = False, - attachments: [str] = None, # pylint: disable=unused-argument + attachments: List[str] = None, # pylint: disable=unused-argument as_user: bool = False, ): args = { @@ -353,7 +353,7 @@ async def files_upload_ex( self, file: Union[str, IOBase] = None, content: str = None, - channels: [str] = None, + channels: List[str] = None, title: str = None, initial_comment: str = None, file_type: str = None, diff --git a/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_event.py b/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_event.py index 689b0b25c..66b810ffb 100644 --- a/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_event.py +++ b/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_event.py @@ -1,6 +1,7 @@ # Copyright (c) Microsoft Corporation. All rights reserved. # Licensed under the MIT License. +from typing import List from botbuilder.adapters.slack.slack_message import SlackMessage @@ -24,7 +25,7 @@ def __init__(self, **kwargs): self.user = kwargs.get("user") self.user_id = kwargs.get("user_id") self.bot_id = kwargs.get("bot_id") - self.actions: [str] = kwargs.get("actions") + self.actions: List[str] = kwargs.get("actions") self.item = kwargs.get("item") self.item_channel = kwargs.get("item_channel") self.files: [] = kwargs.get("files") diff --git a/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_payload.py b/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_payload.py index c05456f69..9b7438619 100644 --- a/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_payload.py +++ b/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_payload.py @@ -8,7 +8,7 @@ class SlackPayload: def __init__(self, **kwargs): - self.type: [str] = kwargs.get("type") + self.type: List[str] = kwargs.get("type") self.token: str = kwargs.get("token") self.channel: str = kwargs.get("channel") self.thread_ts: str = kwargs.get("thread_ts") diff --git a/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_request_body.py b/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_request_body.py index 7990555c7..b8ad4bd06 100644 --- a/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_request_body.py +++ b/libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_request_body.py @@ -1,6 +1,7 @@ # Copyright (c) Microsoft Corporation. All rights reserved. # Licensed under the MIT License. +from typing import List from botbuilder.adapters.slack.slack_event import SlackEvent from botbuilder.adapters.slack.slack_payload import SlackPayload @@ -14,7 +15,7 @@ def __init__(self, **kwargs): self.type = kwargs.get("type") self.event_id = kwargs.get("event_id") self.event_time = kwargs.get("event_time") - self.authed_users: [str] = kwargs.get("authed_users") + self.authed_users: List[str] = kwargs.get("authed_users") self.trigger_id = kwargs.get("trigger_id") self.channel_id = kwargs.get("channel_id") self.user_id = kwargs.get("user_id") diff --git a/libraries/botbuilder-ai/botbuilder/ai/qna/utils/qna_card_builder.py b/libraries/botbuilder-ai/botbuilder/ai/qna/utils/qna_card_builder.py index e450b4ef2..75785c78c 100644 --- a/libraries/botbuilder-ai/botbuilder/ai/qna/utils/qna_card_builder.py +++ b/libraries/botbuilder-ai/botbuilder/ai/qna/utils/qna_card_builder.py @@ -1,6 +1,7 @@ # Copyright (c) Microsoft Corporation. All rights reserved. # Licensed under the MIT License. +from typing import List from botbuilder.core import CardFactory from botbuilder.schema import Activity, ActivityTypes, CardAction, HeroCard @@ -14,7 +15,7 @@ class QnACardBuilder: @staticmethod def get_suggestions_card( - suggestions: [str], card_title: str, card_no_match: str + suggestions: List[str], card_title: str, card_no_match: str ) -> Activity: """ Get active learning suggestions card. diff --git a/libraries/botbuilder-schema/botbuilder/schema/health_results.py b/libraries/botbuilder-schema/botbuilder/schema/health_results.py index 28f7dca9c..6205e68cb 100644 --- a/libraries/botbuilder-schema/botbuilder/schema/health_results.py +++ b/libraries/botbuilder-schema/botbuilder/schema/health_results.py @@ -1,6 +1,7 @@ # Copyright (c) Microsoft Corporation. All rights reserved. # Licensed under the MIT License. +from typing import List from msrest.serialization import Model @@ -19,7 +20,7 @@ def __init__( success: bool = None, authorization: str = None, user_agent: str = None, - messages: [str] = None, + messages: List[str] = None, diagnostics: object = None, **kwargs ) -> None: