Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phone Skill] maindialog update and action manifest #20

Merged
merged 7 commits into from
Mar 9, 2020

Conversation

bobokids
Copy link
Contributor

@bobokids bobokids commented Mar 1, 2020

Purpose

What is the context of this pull request? Why is it being done?
. Update maindialog to waterfall
. add action manifest

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

Tests

Is this covered by existing tests or new ones? If no, why not?

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@xieofxie
Copy link
Contributor

xieofxie commented Mar 2, 2020

Tests failed..

@bobokids bobokids merged commit afa4a09 into master Mar 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the kanel/phone_maindialog branch March 9, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants