Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Commit 407b4f9

Browse files
authored
Merge pull request #3 from microsoft/master
pulling latest from upstream
2 parents 2ecd1e6 + 1281e17 commit 407b4f9

File tree

17 files changed

+292
-270
lines changed

17 files changed

+292
-270
lines changed

docs/tutorials/csharp/virtualassistant.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ A Virtual Assistant app (in C#) that greets a new user.
5454
npm install -g botskills
5555
```
5656

57-
7. Download and install the [Azure Command Line Tools (CLI)](https://docs.microsoft.com/en-us/cli/azure/install-azure-cli-windows?view=azure-cli-latest).
57+
7. Download and install the [Azure Command Line Tools (CLI)](https://docs.microsoft.com/en-us/cli/azure/install-azure-cli-windows?view=azure-cli-latest) **(Version 2.0.64 minimum required)**.
5858
8. Download and install the [Bot Framework Emulator](https://aka.ms/botframework-emulator).
5959

6060
## Create your assistant

lib/csharp/microsoft.bot.builder.solutions/microsoft.bot.builder.solutions/Extensions/ActivityEx.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public static bool IsStartActivity(this Activity activity)
3636
if (activity.Type == ActivityTypes.ConversationUpdate)
3737
{
3838
// When bot is added to the conversation (triggers start only once per conversation)
39-
if (activity.MembersAdded.Any(m => m.Id == activity.Recipient.Id))
39+
if (activity.MembersAdded != null && activity.MembersAdded.Any(m => m.Id == activity.Recipient.Id))
4040
{
4141
return true;
4242
}

lib/typescript/botskills/docs/connect-disconnect.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ botskills disconnect [option]
6868
| --ts | Determine your assistant project structure to be a TypeScript-like structure
6969
| --noTrain | (OPTIONAL) Determine whether the skills connected are not going to be trained (by default they are trained) |
7070
| --dispatchName [name] | (OPTIONAL) Name of your assistant's '.dispatch' file (defaults to the name displayed in your Cognitive Models file) |
71+
| --language [language] | (OPTIONAL) Locale used for LUIS culture (defaults to 'en-us') |
7172
| --dispatchFolder [path] | (OPTIONAL) Path to the folder containing your assistant's '.dispatch' file (defaults to './deployment/resources/dispatch/en' inside your assistant folder) |
7273
| --outFolder [path] | (OPTIONAL) Path for any output file that may be generated (defaults to your assistant's root folder) |
7374
| --lgOutFolder [path] | (OPTIONAL) Path for the LuisGen output (defaults to a 'service' folder inside your assistant's folder) |

lib/typescript/botskills/src/botskills-disconnect.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ program
3636
.option('--ts', 'Determine your assistant project structure to be a TypeScript-like structure')
3737
.option('--noTrain', '[OPTIONAL] Determine whether the skills connected are not going to be trained (by default they are trained)')
3838
.option('--dispatchName [name]', '[OPTIONAL] Name of your assistant\'s \'.dispatch\' file (defaults to the name displayed in your Cognitive Models file)')
39+
.option('--language [language]', '[OPTIONAL] Locale used for LUIS culture (defaults to \'en-us\')')
3940
.option('--dispatchFolder [path]', '[OPTIONAL] Path to the folder containing your assistant\'s \'.dispatch\' file (defaults to \'./deployment/resources/dispatch/en\' inside your assistant folder)')
4041
.option('--outFolder [path]', '[OPTIONAL] Path for any output file that may be generated (defaults to your assistant\'s root folder)')
4142
.option('--lgOutFolder [path]', '[OPTIONAL] Path for the LuisGen output (defaults to a \'service\' folder inside your assistant\'s folder)')
@@ -113,9 +114,6 @@ const language: string = args.language || 'en-us';
113114
configuration.language = language;
114115
const languageCode: string = (language.split('-'))[0];
115116

116-
// luisFolder validation
117-
configuration.luisFolder = args.luisFolder || join(configuration.outFolder, 'Deployment', 'Resources', 'Skills', languageCode);
118-
119117
// dispatchFolder validation
120118
configuration.dispatchFolder = args.dispatchFolder || join(configuration.outFolder, 'Deployment', 'Resources', 'Dispatch', languageCode);
121119

templates/Enterprise-Template/src/csharp/EnterpriseBotSample/EnterpriseBotSample/Extensions/ActivityExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public static bool IsStartActivity(this Activity activity)
3232
if (activity.Type == ActivityTypes.ConversationUpdate)
3333
{
3434
// When bot is added to the conversation (triggers start only once per conversation)
35-
if (activity.MembersAdded.Any(m => m.Id == activity.Recipient.Id))
35+
if (activity.MembersAdded != null && activity.MembersAdded.Any(m => m.Id == activity.Recipient.Id))
3636
{
3737
return true;
3838
}

templates/Enterprise-Template/src/csharp/EnterpriseBotTemplate/EnterpriseTemplate/Extensions/ActivityExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public static bool IsStartActivity(this Activity activity)
3232
if (activity.Type == ActivityTypes.ConversationUpdate)
3333
{
3434
// When bot is added to the conversation (triggers start only once per conversation)
35-
if (activity.MembersAdded.Any(m => m.Id == activity.Recipient.Id))
35+
if (activity.MembersAdded != null && activity.MembersAdded.Any(m => m.Id == activity.Recipient.Id))
3636
{
3737
return true;
3838
}

0 commit comments

Comments
 (0)