Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@Batta32
Copy link
Collaborator

@Batta32 Batta32 commented Jul 17, 2019

Fix #1883

Purpose

What is the context of this pull request? Why is it being done?
Using a path with spaces, the tool fails during the execution of the external commands, we implemented the support for that cases.

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

  • Support of path with spaces in the execution of the external commands
  • Update tests

Tests

Is this covered by existing tests or new ones? If no, why not?
Yes, the connect.test.js and refresh.test.js were updated to cover the changes.

Testing Steps

Using the botskills cli tool

  1. Use a path with spaces which contains the Virtual Assistant or Skill
  2. Connect a Skill to the Virtual Assistant
  3. Check the connection between them finished successfully

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@darrenj darrenj merged commit c89cd0f into master Jul 18, 2019
@pr-triage pr-triage bot added the merged label Jul 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/southworks/botskills/fix-spaces-path branch July 18, 2019 10:29
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
…commands (#1885)

* Fix spaces in path arguments for external commands

* Fix related tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

botskills refresh fails when repo path has spaces

5 participants