This repository was archived by the owner on Jun 30, 2022. It is now read-only.
[Future to Next] Fallback skill & va change #2076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add fallback events in lib * update with new design * fix warning * fix warning * fix issue * fix indentation * remove dll * fix comments * fix warning * fix as comments * fix after discussion * fix comments * remove extra line * fix as comment
* simplify lib change * fix as comments * fix as comments * fix as comments
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612 and
ryanisgrig
|
Mistakenly checked in to future branch. Now move to the next branch~ |
|
The checks on github for next branch seems had some issues --- it always report cannot restore preview lib packages while local build is good. But things work well in future branch. Does anybody know why?
|
|
@DingmaomaoBJTU it probably can't access the myget feed. Try adding lines 6-7 from this file with the aitemplates feed in csproj: |
lauren-mills
approved these changes
Aug 8, 2019
lzc850612
approved these changes
Aug 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
What is the context of this pull request? Why is it being done?
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Tests
Is this covered by existing tests or new ones? If no, why not?
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General
Bots
.lufiles and validated that deployment is successfulDeployment Scripts