LanguageExtension downcast resolution #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terfaces This commit refactors the LanguageExtension interface to eliminate the need for a class loader to convert it to its sub-interfaces JavaExtension and ScalaExtension. Changes: - Removed usage of class loader for conversion. - Introduced methods within LanguageExtension to check if the current implementation is Java or Scala Extension and return specific instance if applicable.
This commit updates unit tests to reflect the changes in the LanguageExtension interface. Changes: - Mocks for JavaExtension and ScalaExtension are updated to return correct values for the newly introduced methods. These updates ensure that tests continue to verify the expected behavior of LanguageExtension.
jdneo
added
the
engineering
jdneo
reviewed
Jul 1, 2024
model/src/main/java/com/microsoft/java/bs/gradle/model/LanguageExtension.java
Outdated
Show resolved
Hide resolved
Changes: - removed @nullable annotation which came from gradle's internal package. - added JavaDoc
Arthurm1
reviewed
Jul 2, 2024
jdneo
approved these changes
Jul 2, 2024
Member
|
Thank you @Tanish-Ranjan for your contribution! You can continue to work on #154 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the usage of a class loader for downcasting
LanguageExtesniontoJavaExtensionandScalaExtension. Previously, the client JVM would attempt to determine the appropriate sub-interface type using a class loader.Changes:
LanguageExtensioninterface:isJavaExtension()andisScalaExtension(): Checks if the current implementation is a specific sub-interface type.getAsJavaExtension()andgetAsScalaExtension(): Returns the instance as the specific sub-interface type if applicable.LanguageExtensioninterface resides. This ensures correct type information is available for downcasting.