From 7ef6eaf1b677c4e6f986de6ac84780caacfeb771 Mon Sep 17 00:00:00 2001 From: Rudy Huyn Date: Fri, 22 Nov 2019 10:36:36 -0800 Subject: [PATCH] Added support for small windows in the graphing calculator (#803) * Add support of small windows * remove extra space * Modify how we manage the tooltip * Fix merge issues --- .../Automation/NarratorAnnouncement.cpp | 10 + .../Common/Automation/NarratorAnnouncement.h | 3 + src/Calculator/Calculator.vcxproj.filters | 6 - src/Calculator/Resources/en-US/Resources.resw | 22 +- .../GraphingCalculator.xaml | 578 ++++++++++++------ .../GraphingCalculator.xaml.cpp | 79 ++- .../GraphingCalculator.xaml.h | 33 +- src/Calculator/Views/MainPage.xaml | 2 +- 8 files changed, 516 insertions(+), 217 deletions(-) diff --git a/src/CalcViewModel/Common/Automation/NarratorAnnouncement.cpp b/src/CalcViewModel/Common/Automation/NarratorAnnouncement.cpp index 5b6d99bd2..33825b085 100644 --- a/src/CalcViewModel/Common/Automation/NarratorAnnouncement.cpp +++ b/src/CalcViewModel/Common/Automation/NarratorAnnouncement.cpp @@ -22,6 +22,7 @@ namespace CalculatorApp::Common::Automation StringReference DisplayCopied(L"DisplayCopied"); StringReference OpenParenthesisCountChanged(L"OpenParenthesisCountChanged"); StringReference NoParenthesisAdded(L"NoParenthesisAdded"); + StringReference GraphModeChanged(L"GraphModeChanged"); } } @@ -139,3 +140,12 @@ NarratorAnnouncement ^ CalculatorAnnouncement::GetNoRightParenthesisAddedAnnounc AutomationNotificationKind::ActionCompleted, AutomationNotificationProcessing::ImportantMostRecent); } + +NarratorAnnouncement ^ CalculatorAnnouncement::GetGraphModeChangedAnnouncement(Platform::String ^ announcement) +{ + return ref new NarratorAnnouncement( + announcement, + CalculatorActivityIds::GraphModeChanged, + AutomationNotificationKind::ActionCompleted, + AutomationNotificationProcessing::ImportantMostRecent); +} diff --git a/src/CalcViewModel/Common/Automation/NarratorAnnouncement.h b/src/CalcViewModel/Common/Automation/NarratorAnnouncement.h index c4c0c5266..e508675fb 100644 --- a/src/CalcViewModel/Common/Automation/NarratorAnnouncement.h +++ b/src/CalcViewModel/Common/Automation/NarratorAnnouncement.h @@ -92,5 +92,8 @@ public static NarratorAnnouncement ^ GetOpenParenthesisCountChangedAnnouncement(Platform::String ^ announcement); static NarratorAnnouncement ^ GetNoRightParenthesisAddedAnnouncement(Platform::String ^ announcement); + + static NarratorAnnouncement ^ GetGraphModeChangedAnnouncement(Platform::String ^ announcement); + }; } diff --git a/src/Calculator/Calculator.vcxproj.filters b/src/Calculator/Calculator.vcxproj.filters index 1a9988b2d..6f8b28c4d 100644 --- a/src/Calculator/Calculator.vcxproj.filters +++ b/src/Calculator/Calculator.vcxproj.filters @@ -1489,11 +1489,5 @@ - - - - - - \ No newline at end of file diff --git a/src/Calculator/Resources/en-US/Resources.resw b/src/Calculator/Resources/en-US/Resources.resw index f014efb21..6a1b8c087 100644 --- a/src/Calculator/Resources/en-US/Resources.resw +++ b/src/Calculator/Resources/en-US/Resources.resw @@ -3698,4 +3698,24 @@ Unable to calculate the range for this function. Error displayed when Range is not returned from the analyzer. - + + Switch to equation mode + Used in Graphing Calculator to switch the view to the equation mode + + + Switch to graph mode + Used in Graphing Calculator to switch the view to the graph mode + + + Switch to equation mode + Used in Graphing Calculator to switch the view to the equation mode + + + Current mode is equation mode + Announcement used in Graphing Calculator when switching to the equation mode + + + Current mode is graph mode + Announcement used in Graphing Calculator when switching to the graph mode + + \ No newline at end of file diff --git a/src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml b/src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml index 3a83f90a8..8947a61db 100644 --- a/src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml +++ b/src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml @@ -1,6 +1,7 @@ - - - - - - + + + + + + + + + + + +