Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Contributing #431

Merged
merged 30 commits into from Apr 10, 2019

Conversation

Projects
None yet
4 participants
@grochocki
Copy link
Contributor

commented Apr 4, 2019

Updating Contributing documentation:

  • Adding reference to spec repository for feature development
  • Adding localization issue template
  • Adding clarifications for contributions and PRs

grochocki added some commits Apr 3, 2019

@grochocki grochocki requested a review from HowardWolosky Apr 4, 2019

Show resolved Hide resolved CONTRIBUTING.md Outdated

grochocki added some commits Apr 4, 2019

@HowardWolosky
Copy link
Member

left a comment

Thanks for merging in the changes from my private branch. I hadn't gotten around to getting the PR out. There are some additional changes that I think you should apply as well...

Show resolved Hide resolved docs/NewFeatureProcess.md Outdated
Show resolved Hide resolved docs/NewFeatureProcess.md Outdated
Show resolved Hide resolved docs/NewFeatureProcess.md Outdated
Show resolved Hide resolved docs/NewFeatureProcess.md Outdated
Show resolved Hide resolved docs/NewFeatureProcess.md Outdated
Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved .github/ISSUE_TEMPLATE/feature_request.md Outdated
Show resolved Hide resolved .github/ISSUE_TEMPLATE/bug_report.md Outdated
Show resolved Hide resolved .github/ISSUE_TEMPLATE/localization_suggestion.md Outdated
Show resolved Hide resolved .github/ISSUE_TEMPLATE/localization_suggestion.md Outdated

HowardWolosky and others added some commits Apr 5, 2019

Update .github/ISSUE_TEMPLATE/localization_suggestion.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>
Update docs/NewFeatureProcess.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>
Update docs/NewFeatureProcess.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>
Update docs/NewFeatureProcess.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>
Update CONTRIBUTING.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>
Update .github/ISSUE_TEMPLATE/bug_report.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>

@grochocki grochocki requested a review from HowardWolosky Apr 5, 2019

@HowardWolosky
Copy link
Member

left a comment

Minor additional feedback on the updates.

Show resolved Hide resolved .github/ISSUE_TEMPLATE/feature_request.md Outdated
Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved docs/NewFeatureProcess.md Outdated

HowardWolosky and others added some commits Apr 5, 2019

Update .github/ISSUE_TEMPLATE/feature_request.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>
Update CONTRIBUTING.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>

HowardWolosky and others added some commits Apr 5, 2019

Update CONTRIBUTING.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>
Update CONTRIBUTING.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>
Update CONTRIBUTING.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>
Update CONTRIBUTING.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>
Update docs/NewFeatureProcess.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>

@grochocki grochocki requested a review from HowardWolosky Apr 5, 2019

Show resolved Hide resolved docs/NewFeatureProcess.md Outdated
Update docs/NewFeatureProcess.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>

@grochocki grochocki requested a review from HowardWolosky Apr 8, 2019

Update .github/ISSUE_TEMPLATE/localization_suggestion.md
Co-Authored-By: grochocki <grochocki@users.noreply.github.com>

@grochocki grochocki merged commit 47a2741 into microsoft:master Apr 10, 2019

6 checks passed

Calculator-CI Build #0.1904.905.0 succeeded
Details
Calculator-CI (Build x64) Build x64 succeeded
Details
Calculator-CI (CleanUpUnitTestsx64) CleanUpUnitTestsx64 succeeded
Details
Calculator-CI (Package) Package succeeded
Details
Calculator-CI (UnitTests x64) UnitTests x64 succeeded
Details
license/cla All CLA requirements met.
Details

@grochocki grochocki deleted the grochocki:contributing branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.