From 3f2f269ac665545a0a0a2d95b7da62dbca8871a8 Mon Sep 17 00:00:00 2001 From: Aaron Date: Tue, 25 May 2021 16:37:42 -0700 Subject: [PATCH 1/5] Updating build script to remove unnecessary "Italic" from static instances For whatever reason glyphslib sets the familyName of the font to include the "Italic" name. I had corrected the variable font instance, but not the static instances. --- build.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/build.py b/build.py index c3fe61536..e65cf3be8 100644 --- a/build.py +++ b/build.py @@ -202,9 +202,13 @@ def build_font_static( name: str, ) -> None: prepare_fonts(designspace, name) + generator = fontmake.instantiator.Instantiator.from_designspace(designspace) instance = generator.generate_instance(instance_descriptor) - compile_static_and_save(instance, name) + instance.info.familyName = instance.info.familyName.replace(" Italic","") + if instance.info.styleMapFamilyName: + instance.info.styleMapFamilyName = instance.info.styleMapFamilyName.replace(" Italic","") + compile_static_and_save(instance, name.replace(" Italic","")) # Export fonts From f50057f8e69ad9c0a4e59f699bf7c9492b20c9dd Mon Sep 17 00:00:00 2001 From: Aaron Date: Wed, 26 May 2021 10:11:14 -0700 Subject: [PATCH 2/5] Fixing interpolation bugs Double-checked to make sure that the hinting didn't break in fixing these. --- .../glyphs/bar_bar_equal_middle.seq.glif | 2 +- .../CascadiaCode-BoldItalic.ufo/glyphs/fi.glif | 4 ++-- .../glyphs/baht.B_R_A_C_K_E_T_.600.glif | 4 ++-- .../glyphs/bar_bar_equal_middle.seq.glif | 2 +- .../glyphs/dollar.B_R_A_C_K_E_T_.600.glif | 12 ++++++------ .../glyphs/fi.glif | 4 ++-- .../glyphs/numbersign_question.liga.glif | 16 ++++++++-------- 7 files changed, 22 insertions(+), 22 deletions(-) diff --git a/sources/CascadiaCode-BoldItalic.ufo/glyphs/bar_bar_equal_middle.seq.glif b/sources/CascadiaCode-BoldItalic.ufo/glyphs/bar_bar_equal_middle.seq.glif index 15cdcdee3..6a1ce2cee 100644 --- a/sources/CascadiaCode-BoldItalic.ufo/glyphs/bar_bar_equal_middle.seq.glif +++ b/sources/CascadiaCode-BoldItalic.ufo/glyphs/bar_bar_equal_middle.seq.glif @@ -26,8 +26,8 @@ - + diff --git a/sources/CascadiaCode-BoldItalic.ufo/glyphs/fi.glif b/sources/CascadiaCode-BoldItalic.ufo/glyphs/fi.glif index 51cfdb396..a5db7a641 100644 --- a/sources/CascadiaCode-BoldItalic.ufo/glyphs/fi.glif +++ b/sources/CascadiaCode-BoldItalic.ufo/glyphs/fi.glif @@ -4,16 +4,16 @@ - + - + diff --git a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/baht.B_R_A_C_K_E_T_.600.glif b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/baht.B_R_A_C_K_E_T_.600.glif index 857f73bc9..86e6690a2 100644 --- a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/baht.B_R_A_C_K_E_T_.600.glif +++ b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/baht.B_R_A_C_K_E_T_.600.glif @@ -3,16 +3,16 @@ + - - + diff --git a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/bar_bar_equal_middle.seq.glif b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/bar_bar_equal_middle.seq.glif index 89fa939b2..847241643 100644 --- a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/bar_bar_equal_middle.seq.glif +++ b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/bar_bar_equal_middle.seq.glif @@ -26,8 +26,8 @@ - + diff --git a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/dollar.B_R_A_C_K_E_T_.600.glif b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/dollar.B_R_A_C_K_E_T_.600.glif index 70db682bf..dde585ae8 100644 --- a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/dollar.B_R_A_C_K_E_T_.600.glif +++ b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/dollar.B_R_A_C_K_E_T_.600.glif @@ -2,18 +2,18 @@ - - - - - - + + + + + + diff --git a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/fi.glif b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/fi.glif index f3f081cab..6dde7689e 100644 --- a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/fi.glif +++ b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/fi.glif @@ -4,16 +4,16 @@ - + - + diff --git a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/numbersign_question.liga.glif b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/numbersign_question.liga.glif index e2c31e754..ed3262bc3 100644 --- a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/numbersign_question.liga.glif +++ b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/numbersign_question.liga.glif @@ -3,10 +3,10 @@ - - - - + + + + @@ -15,10 +15,10 @@ - - - - + + + + From 29024683ce72144cd210dc57861409bdc47c2f39 Mon Sep 17 00:00:00 2001 From: Aaron Date: Wed, 26 May 2021 10:11:30 -0700 Subject: [PATCH 3/5] Update build.py --- build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.py b/build.py index e65cf3be8..1cf24879f 100644 --- a/build.py +++ b/build.py @@ -23,7 +23,7 @@ from vttmisc import tsi1, tsic VERSION_YEAR_MONTH = 2105 -VERSION_DAY = 24 +VERSION_DAY = 26 OUTPUT_DIR = Path("build") OUTPUT_OTF_DIR = OUTPUT_DIR / "otf" From 28da1e7741fc66ce2eeac544f1bd16e2a714cba3 Mon Sep 17 00:00:00 2001 From: Aaron Date: Wed, 26 May 2021 10:18:45 -0700 Subject: [PATCH 4/5] Minor tweak to fi ligature shape I was there. I updated it. --- .../glyphs/fi.glif | 20 ++++++++-------- .../glyphs/fi.glif | 24 +++++++++---------- .../CascadiaCode-Italic.ufo/glyphs/fi.glif | 24 +++++++++---------- 3 files changed, 34 insertions(+), 34 deletions(-) diff --git a/sources/CascadiaCode-BoldItalic.ufo/glyphs/fi.glif b/sources/CascadiaCode-BoldItalic.ufo/glyphs/fi.glif index a5db7a641..b79e152ec 100644 --- a/sources/CascadiaCode-BoldItalic.ufo/glyphs/fi.glif +++ b/sources/CascadiaCode-BoldItalic.ufo/glyphs/fi.glif @@ -23,16 +23,16 @@ - - - - - - - - - - + + + + + + + + + + diff --git a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/fi.glif b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/fi.glif index 6dde7689e..46ef73a6c 100644 --- a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/fi.glif +++ b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/fi.glif @@ -22,18 +22,18 @@ - - - - - - - - - - - - + + + + + + + + + + + + diff --git a/sources/CascadiaCode-Italic.ufo/glyphs/fi.glif b/sources/CascadiaCode-Italic.ufo/glyphs/fi.glif index 0b7d0662d..5e3eedc12 100644 --- a/sources/CascadiaCode-Italic.ufo/glyphs/fi.glif +++ b/sources/CascadiaCode-Italic.ufo/glyphs/fi.glif @@ -22,18 +22,18 @@ - - - - - - - - - - - - + + + + + + + + + + + + From fb338e29e38ee1ed8e850792e634a976e22ff13b Mon Sep 17 00:00:00 2001 From: Aaron Date: Wed, 26 May 2021 10:21:35 -0700 Subject: [PATCH 5/5] Last one? --- .../glyphs/numbersign_underscore_parenleft.liga.glif | 2 +- .../glyphs/numbersign_underscore_parenleft.liga.glif | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sources/CascadiaCode-BoldItalic.ufo/glyphs/numbersign_underscore_parenleft.liga.glif b/sources/CascadiaCode-BoldItalic.ufo/glyphs/numbersign_underscore_parenleft.liga.glif index c5a4e678a..f39ce01f0 100644 --- a/sources/CascadiaCode-BoldItalic.ufo/glyphs/numbersign_underscore_parenleft.liga.glif +++ b/sources/CascadiaCode-BoldItalic.ufo/glyphs/numbersign_underscore_parenleft.liga.glif @@ -49,10 +49,10 @@ - + diff --git a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/numbersign_underscore_parenleft.liga.glif b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/numbersign_underscore_parenleft.liga.glif index 068970c4e..16609ab0a 100644 --- a/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/numbersign_underscore_parenleft.liga.glif +++ b/sources/CascadiaCode-ExtraLightItalic.ufo/glyphs/numbersign_underscore_parenleft.liga.glif @@ -49,10 +49,10 @@ - +