-
Notifications
You must be signed in to change notification settings - Fork 643
Add recipe for branch-based secrets management #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is great! |
|
@SaraSp @cloudbeatsch flagging for review, thanks! |
cloudbeatsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I would invite @kevinhartman to take a look at the secrets part with node. We recently opened a story in our current project because in ACI, env vars are visible in the portal (thats how i understood what @kevinhartman and narmatha reporting). So is the env the best place to put secrets? Is there a different place for node containers that we should place secrets? |
|
@charleszipp I will message @kevinhartman to add a recipe for node secrets! |
|
@charleszipp The recommendation for using dotenv in Node came from @tobecodex so perhaps he can add more context. Personally, I like the way the section on Enhanced-Security Applications puts it: using environment variables is fine for most applications unless you have specific additional security requirements (in which case you'd likely have a security review, pentesting, etc. all set up which will inform the best enhanced security strategy for your use-case). |
fnocera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. This is something we can build on and add recipes for different languages etc.
continuous-deployment/secrets-management/recipes/azure-devops/secrets-per-branch.md
Outdated
Show resolved
Hide resolved
continuous-deployment/secrets-management/recipes/azure-devops/secrets-per-branch.md
Outdated
Show resolved
Hide resolved
continuous-deployment/secrets-management/recipes/azure-devops/secrets-per-branch.md
Outdated
Show resolved
Hide resolved
continuous-deployment/secrets-management/recipes/azure-devops/secrets-per-branch.md
Outdated
Show resolved
Hide resolved
…secrets-per-branch.md Co-Authored-By: David Khourshid <davidkpiano@gmail.com>
…secrets-per-branch.md Co-Authored-By: David Khourshid <davidkpiano@gmail.com>
…secrets-per-branch.md Co-Authored-By: David Khourshid <davidkpiano@gmail.com>
Co-Authored-By: David Khourshid <davidkpiano@gmail.com>
This pull request adds a section about branch-based secrets management to the engineering playbook. The section is based on findings from a customer project and answers questions such as:
The section is included as part of the continuous deployment heading since it already has some prior content around secrets management.