Add recipe for bash script code reviews#73
Merged
cloudbeatsch merged 1 commit intomicrosoft:masterfrom Oct 30, 2019
c-w:bash-code-reviews
Merged
Add recipe for bash script code reviews#73cloudbeatsch merged 1 commit intomicrosoft:masterfrom c-w:bash-code-reviews
cloudbeatsch merged 1 commit intomicrosoft:masterfrom
c-w:bash-code-reviews
Conversation
fnocera
approved these changes
Oct 29, 2019
Contributor
fnocera
left a comment
fnocera
left a comment
There was a problem hiding this comment.
Awesome addition, thanks!
Contributor
|
@SaraSp @cloudbeatsch flagging for review, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a section about bash script code reviews to the engineering playbook. The section is based on findings from a customer project and answers questions such as: