Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoE Starter Kit - Feature]: to many host domains for env var #8438

Open
lukas-nC opened this issue Jun 7, 2024 · 3 comments
Open

[CoE Starter Kit - Feature]: to many host domains for env var #8438

lukas-nC opened this issue Jun 7, 2024 · 3 comments
Assignees
Labels
coe-starter-kit CoE Starter Kit issues enhancement New feature or request

Comments

@lukas-nC
Copy link

lukas-nC commented Jun 7, 2024

Is your feature request related to a problem? Please describe.

Hi,
i've the problem that a tenant has to many custom domains to concatenate them for the env var (over 3000 characters)

Describe the solution you'd like

make a call via graph to get all custom domains

Describe alternatives you've considered

No response

Additional context?

No response

AB#3511

@lukas-nC lukas-nC added coe-starter-kit CoE Starter Kit issues enhancement New feature or request labels Jun 7, 2024
@Jenefer-Monroe
Copy link
Collaborator

Hello, do you have an example of the graph call that would be needed?

@Jenefer-Monroe Jenefer-Monroe self-assigned this Jun 7, 2024
@petepuu
Copy link

petepuu commented Jun 9, 2024

@Jenefer-Monroe Graph call is https://graph.microsoft.com/v1.0/domains but CoE service account would need Domain.Read.All permissions for this to work.

https://learn.microsoft.com/en-us/graph/api/domain-list?view=graph-rest-1.0&tabs=http#permissions

@Jenefer-Monroe
Copy link
Collaborator

Thanks Pete! We could consider having another env var that switches though, and only calls that for folks that set it up correctly. IE something like Domains Via Env Var, (true by default)

I'm afraid with competing priorities this will sit on the backlog for a bit so if someone implements and tests, do let me know, that will make it more likely to ship soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coe-starter-kit CoE Starter Kit issues enhancement New feature or request
Projects
Status: Todo ✏️
Development

No branches or pull requests

3 participants