Skip to content

Conversation

@WesHaze
Copy link
Contributor

@WesHaze WesHaze commented Mar 15, 2025

Moves guard statement up in the NuGetComponentDetector to avoid unnecessary throw in the FileInfo constructor

… avoid uncessary throw of ArgumentNullException in FileInfo constructor
@WesHaze WesHaze requested a review from a team as a code owner March 15, 2025 14:06
@WesHaze WesHaze requested a review from grvillic March 15, 2025 14:06
Copy link
Member

@pauld-msft pauld-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this!

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.6%. Comparing base (a72b623) to head (56b27f4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...etection.Detectors/nuget/NuGetComponentDetector.cs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1371   +/-   ##
=====================================
  Coverage   89.6%   89.6%           
=====================================
  Files        402     402           
  Lines      31734   31734           
  Branches    1959    1959           
=====================================
  Hits       28465   28465           
  Misses      2852    2852           
  Partials     417     417           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pauld-msft pauld-msft merged commit 9379136 into microsoft:main Apr 4, 2025
21 of 23 checks passed
@github-actions
Copy link

github-actions bot commented Apr 4, 2025

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants