Skip to content

Conversation

@tofay
Copy link
Contributor

@tofay tofay commented Jul 8, 2022

Some Azure for Operators teams have successfully been using the off by default poetry detector for the last few months. We've not seen any issues with it, and have periodically verified that it's detecting the same dependencies as another dependency detection tool we used.

We'd like to enable it by default so other teams can benefit without having to explicitly enable it.

Signed-off-by: Tom Fay tomfay@microsoft.com

Signed-off-by: Tom Fay <tomfay@microsoft.com>
@tofay tofay requested a review from a team as a code owner July 8, 2022 18:29
@tofay tofay requested a review from chsalgado July 8, 2022 18:29
Signed-off-by: Tom Fay <tomfay@microsoft.com>
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@JamieMagee
Copy link
Member

Failing verification test is expected, as Poetry scanner is now being run.

@tofay tofay merged commit 79c4f54 into main Jul 11, 2022
@tofay tofay deleted the tofay/enable-poetry branch July 11, 2022 17:41
JamieMagee added a commit that referenced this pull request Jul 26, 2022
#167 enabled the poetry detector by default. We don't want to globally enable it yet, but instead move from an opt-in to an experimental detector.
JamieMagee added a commit that referenced this pull request Jul 26, 2022
#167 enabled the poetry detector by default. We don't want to globally enable it yet, but instead move from an opt-in to an experimental detector.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants