Special case scratch base image #173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a container image has a image.base.ref.name of scratch then determine that there is no base image, rather than trying to pull "scratch".
In v1.1.9 component-detection tries to pull the "scratch@" image, which fails causing the following log to be displayed:
In v1.2.4 component-detection still tries to pull the "scratch@" image but this time the TryPullImageAsync call at
component-detection/src/Microsoft.ComponentDetection.Detectors/linux/LinuxContainerDetector.cs
Line 225 in 0319816
Looking at the changes between those releases, possibly the bump of Docker.Dotnet from 3.125.4 to 3.124.5 caused this change of behaviour. I can't verify that easily though as I'm hitting dotnet/Docker.DotNet#554, hence the bump to Docker.Dotnet to 3.125.10
Anyway, it seems sensible to special case scratch in this case.