Add missing VcpkgComponent converter and use port version as int #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
VcpkgComponent detector is still in piloting phase, which means is disabled by default. We noticed we were missing the TypedComponentConverter for this new type, which was breaking any wrapper tool looking to deserialize the output json file.
We also noticed that port versions are set as integers on GitHub rather than string, hence we are updating the component to reflect this value.
See sample port version file in VCPKG Forge: https://github.com/microsoft/vcpkg/blob/master/versions/w-/wampcc.json