Skip to content

Conversation

@amitla1
Copy link
Contributor

@amitla1 amitla1 commented Aug 23, 2022

Related: #196

Added a try-catch statement in the OnFileFound method for the Docker component because component detection was attempting to scan files that are named like a Dockerfile but aren't really a Dockerfile which was causing an error.

@amitla1 amitla1 requested a review from a team as a code owner August 23, 2022 17:22
@amitla1 amitla1 requested a review from grvillic August 23, 2022 17:22
@github-actions
Copy link

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Copy link
Member

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a little more context on what the changes you made were and why they were made to the PR description. I know this is a small change, but it's a good habit to get into and can help us track down issues later.

Copy link
Member

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending fix for indentation warning

Elements should have the same indentation

@JamieMagee JamieMagee enabled auto-merge (squash) August 24, 2022 18:52
@JamieMagee JamieMagee merged commit f4adb6f into main Aug 24, 2022
@JamieMagee JamieMagee deleted the users/avannikumar/nondocker-file-parse-issue branch August 24, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants