-
Notifications
You must be signed in to change notification settings - Fork 114
Fix for Bug 196 #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Bug 196 #217
Conversation
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
src/Microsoft.ComponentDetection.Detectors/dockerfile/DockerfileComponentDetector.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/dockerfile/DockerfileComponentDetector.cs
Outdated
Show resolved
Hide resolved
JamieMagee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a little more context on what the changes you made were and why they were made to the PR description. I know this is a small change, but it's a good habit to get into and can help us track down issues later.
…leComponentDetector.cs Co-authored-by: Jamie Magee <jamie.magee@gmail.com>
…leComponentDetector.cs Co-authored-by: Jamie Magee <jamie.magee@gmail.com>
JamieMagee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending fix for indentation warning
Elements should have the same indentation
Related: #196
Added a try-catch statement in the OnFileFound method for the Docker component because component detection was attempting to scan files that are named like a Dockerfile but aren't really a Dockerfile which was causing an error.