Skip to content

Analyzer Warnings SA-1614, SA-1615, SA-1616, SA-1617 #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 9, 2022
Merged

Analyzer Warnings SA-1614, SA-1615, SA-1616, SA-1617 #262

merged 7 commits into from
Sep 9, 2022

Conversation

@Omotola
Copy link
Contributor

@Omotola Omotola commented Sep 8, 2022 •
edited
Loading

Issue #202

  • SA-1614,
  • SA-1615,
  • SA-1616,
  • SA-1617

@Omotola Omotola requested a review from a team as a code owner September 8, 2022 16:46
@Omotola Omotola requested a review from grvillic September 8, 2022 16:46
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@Omotola Omotola changed the title Addressing return statement documentation violations.. Analyzer Warnings SA-1614, SA-1615, SA-1616, SA-1617 Sep 9, 2022
grvillic
grvillic reviewed Sep 9, 2022
View reviewed changes
src/Microsoft.ComponentDetection.Common/DockerReference/DockerRegex.cs
public static Regex Anchored(params Regex[] regexps)
{
return new Regex($"^{Expression(regexps).ToString()}$");
}
Copy link
Collaborator

@grvillic grvillic Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a lot of warnings about "Element parameter documentation should have text" see PR comments by GitHub Actions. Additionally, there are some other new warnings "Code should not contain multiple blank lines in a row"

@Omotola Omotola merged commit eeae9da into main Sep 9, 2022
@Omotola Omotola deleted the users/oakeredolu/returnsstatementdocuemntation branch September 9, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grvillic grvillic grvillic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Omotola @grvillic