Skip to content

Conversation

@RushabhBhansali
Copy link
Contributor

@RushabhBhansali RushabhBhansali commented Oct 7, 2022

Summary

Previous release (2.0.1) failed during publishing step (failure). This is a fix for it.

Rootcause:
after .net6 migration the default publishing step was generating multiple asset files in the ./bin folder. This was causing failure in Publish CLI tool step, since its only expecting single file under ./bin.

due to .net6 migration , it was required that we add `-p:IncludeAllContentForSelfExtract=true (source).

Testing:

  • locally ran dotnet publish --configuration Release --output ./bin --self-contained --runtime win-x64 -p:PublishSingleFile=true -p:IncludeAllContentForSelfExtract=true -p:DebugType=None -p:PublishTrimmed=false ./src/Microsoft.ComponentDetection command to validate that only single file is generated.
  • validated that generted .exe file is able to run properly and scan components on windows platform.

@RushabhBhansali RushabhBhansali requested a review from a team as a code owner October 7, 2022 20:11
@JamieMagee
Copy link
Member

Third time's the charm!

@JamieMagee JamieMagee merged commit 4335896 into main Oct 7, 2022
@JamieMagee JamieMagee deleted the users/rbhansali/release-fix-single-asset branch October 7, 2022 20:39
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants