Skip to content

staging ci #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2020
Merged

staging ci #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
600d992
test if num workers fixes
jiata Jun 24, 2020
551634b
use minified data
jiata Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,7 +771,7 @@ def ar_vid_path(tmp_session) -> str:
def ar_milk_bottle_path(tmp_session) -> str:
""" Returns the path of the milk bottle action dataset. """
return unzip_url(
ar_urls.milk_bottle_action_path,
ar_urls.milk_bottle_action_minified_path,
fpath=tmp_session,
dest=tmp_session,
exist_ok=True,
Expand Down
9 changes: 7 additions & 2 deletions tests/unit/action_recognition/test_action_recognition_notebooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import pytest
import scrapbook as sb

from utils_cv.common.data import unzip_url
Copy link
Contributor

@PatrickBue PatrickBue Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] "unzip_url" not used

from utils_cv.action_recognition.data import Urls

# Unless manually modified, python3 should be
Expand All @@ -33,15 +34,19 @@ def test_00_notebook_run(action_recognition_notebooks):


@pytest.mark.notebooks
def test_01_notebook_run(action_recognition_notebooks):
def test_01_notebook_run(
action_recognition_notebooks,
ar_milk_bottle_path
):
notebook_path = action_recognition_notebooks["01"]
pm.execute_notebook(
notebook_path,
OUTPUT_NOTEBOOK,
parameters=dict(
PM_VERSION=pm.__version__,
DATA_PATH=ar_milk_bottle_path,
MODEL_INPUT_SIZE=8,
EPOCHS=2,
EPOCHS=1,
BATCH_SIZE=8,
LR=0.001,
),
Expand Down
3 changes: 3 additions & 0 deletions utils_cv/action_recognition/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ class Urls:

# testing datasets
milk_bottle_action_path = urljoin(base, "milkBottleActions.zip")
milk_bottle_action_minified_path = urljoin(
base, "milkBottleActions_minified.zip"
)

# milk bottle action split test files
milk_bottle_action_train_split = urljoin(
Expand Down