Some uses of co_await were not protected by WINRT_IMPL_COROUTINES
#1002
Conversation
strings/base_coroutine_foundation.h
Outdated
| private: | ||
| static fire_and_forget cancel_asynchronously(Async async) | ||
| { | ||
| #ifdef WINRT_IMPL_COROUTINES |
There was a problem hiding this comment.
Why not call submit_threadpool_callback instead of changing the semantics of this function?
There was a problem hiding this comment.
Yes, I had a note to make this fix better, but this is to unblock "cannot build because of compiler errors" which is significantly more urgent.
There was a problem hiding this comment.
Could this type just be excluded entirely? Seems only to be used by operator co_await further down in the file (which is also conditioned on WINRT_IMPL_COROUTINES).
As is, I'd expect this to still give compilation errors, but of the form "function has no return"
There was a problem hiding this comment.
Okay, I went and did it.
There was a problem hiding this comment.
Let's try to avoid further feature creep. It's useful to have fixes stand alone in PRs so they can easily be rolled back and reapplied if needed.
There was a problem hiding this comment.
The previous fix was incomplete. It kept the compiler happy but didn't preserve behavior.
There was a problem hiding this comment.
@dunhor Ooh, good point. I missed that it's used only by co_await. Let me see what happens if I take it out entirely.
There was a problem hiding this comment.
@dunhor Okay, it works. I had to comment out a boatload of tests that used co_await, but the rest of them build successfully when WINRT_IMPL_COROUTINES is disabled.
Fixes #1001