Avoid spurious WINRT_NATVIS redefinition warning #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you pass `-DWINRT_NATVIS` to the compiler, it defines the preprocessor symbol to `1`, as if you had written ```cpp #define WINRT_NATVIS 1 ``` This causes debug builds to generate a macro redefinition warning because the debug build force-defines `WINRT_NATVIS` as the empty macro. We don't really care what it defined to, as long as it's defined. Guard the redefinition to avoid the spurious warning.
Member
Author
|
The Windows build system uses |
kennykerr
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you pass
-DWINRT_NATVISto the compiler (to force natvis support even in retail builds), it defines the preprocessor symbol to1, as if you had writtenThis causes debug builds to generate a macro redefinition warning because the debug build force-defines
WINRT_NATVISas the empty macro.We don't really care what it defined to, as long as it's defined. Guard the redefinition to avoid the spurious warning.