Lay groundwork for localizing VSIX templates and remove Dev15 build cruft #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple big changes to the VSIX in this PR:
Lay foundation for VSIX localization
(Copied this technique from microsoft/WindowsAppSDK#1341)
There is an undocumented method for localizing string resources in VS project and item templates. Firstly, the extension containing the templates must provide a VSPackage. Next, a
VSPackage.resx(Visual Studio first looks for theVSPackageresource stream) is added to the extension project to hold the string resources; the IDs of these resources must be integers (specifically, within the range of aunsigned int). Finally, the Name and Description elements in each.vstemplate's<TemplateData>section so that:Packageattribute is the GUID assigned to the extension's VSPackageIDattribute is the ID of the string resource as defined in the.resxThe convention that we will use for choosing resource IDs is as follows:
.resxdesigner use of a lexical sort.Remove Dev15 props/targets build cruft
Since the release of Dev16 (Visual Studio 2019), the props and targets that provide build support have shipped in the NuGet package, and are no longer needed in the VSIX. This change removes these unneeded files.