-
Notifications
You must be signed in to change notification settings - Fork 262
Add visualizer for winrt::Windows::UI::Color #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why not use an hex RGBA color format? Something like Also what if one if the value fits in a single digit? Do you get |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
agree - can we just remove the spaces? |
|
Great addition - thanks! |
|
This is funny, I was suggesting putting alpha at the end, as CSS uses that ( |
natvis/cppwinrt.natvis
Outdated
| </Type> | ||
| <!--Primitive type visualizers--> | ||
| <Type Name="winrt::Windows::UI::Color"> | ||
| <DisplayString># {A,nvoXb} {R,nvoXb} {G,nvoXb} {B,nvoXb}</DisplayString> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the spaces and confirm that leading zeroes are emitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish there was a "half-space" character. I added the spaces so it would be easier to see each byte. I will confirm the single-digit case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the spaces and confirmed that, yes, byte values less than 0x10 have the leading zero added.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Make it look more like a Color value:
# 7F 80 80 40