Add Static Library project template. #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaanstra
force-pushed
the
user/jlaans/static-library-template
branch
from
9dca0ab to
fb3989c
Compare
Scottj1s
reviewed
Oct 29, 2019
Scottj1s
reviewed
Oct 29, 2019
vsix/ProjectTemplates/VC/Windows Universal/StaticLibrary/PropertySheet.props
Outdated
Show resolved
Hide resolved
Contributor
Author
Scottj1s
reviewed
Oct 29, 2019
| <Name>Static Library (C++/WinRT)</Name> | ||
| <Description>A project for a C++/WinRT Static Library that can be used by a Universal Windows Platform app</Description> | ||
| <ProjectType>VC</ProjectType> | ||
| <SortOrder>3000</SortOrder> |
Member
There was a problem hiding this comment.
Note that for VS 2019, you'll also want to add an entry for this template into project-metadata.json, so that it shows up on keyword filters. I would use a sort order value there of maybe 215.5, so it shows up just beneath the runtime component project. Example PR:
https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/162259
Contributor
Author
There was a problem hiding this comment.
Cool, I'll submit that separate.
Contributor
Author
There was a problem hiding this comment.
@Scottj1s looks like I don't have permissions to create PRs there. Can I leave this part to you?
Scottj1s
reviewed
Oct 29, 2019
vsix/ProjectTemplates/VC/Windows Universal/StaticLibrary/cppwinrt_StaticLibrary.vstemplate
Outdated
Show resolved
Hide resolved
Scottj1s
reviewed
Oct 29, 2019
vsix/ProjectTemplates/VC/Windows Universal/WindowsRuntimeComponent/module.g.cpp
Show resolved
Hide resolved
Scottj1s
reviewed
Oct 29, 2019
vsix/ProjectTemplates/VC/Windows Universal/StaticLibrary/readme.txt
Outdated
Show resolved
Hide resolved
Scottj1s
reviewed
Oct 29, 2019
Scottj1s
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a static library project with the same setup as those in the NuGetTest.sln.
Additionally I fixed a few cases where CX winmd generation was still enabled in other project templates.
There's additional setup required in the consuming project which I can't add to this project template. I think there might be ways for cppwinrt.exe to generate the correct module.g.cpp but since that's not available today, I'm not sure how to communicate this. Thoughts?