Add a better default for CppWinRTGenerateWindowsMetadata for CX projects. #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottj1s
reviewed
Nov 1, 2019
| <!-- For CX projects, CppWinRT will never output a winmd--> | ||
| <!-- NOTE: We don't set a default here as the default requires evaluation of project references | ||
| and this is done by the ComputeCppWinRTResolvedWinMD target. --> | ||
| <CppWinRTGenerateWindowsMetadata Condition="'$(CppWinRTGenerateWindowsMetadata)' == '' AND '$(CppWinRTProjectLanguage)' == 'C++/CX' ">false</CppWinRTGenerateWindowsMetadata> |
Member
There was a problem hiding this comment.
this line is redundant, same with the pair of checks below (line 33) - checking XamlLanguage == 'C++' should suffice
Scottj1s
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #404, we added a property to enable Windows Metadata. We calculate a default is one is not specified, but there are a few cases where we know we should disable it without the need to calculate anything.
If the project specifically set a property to indicate it's a CX project, we will never generate a WinMD and we can therefore set CppWinRTGenerateWindowsMetadata to false.