Accommodate other "key not found" errors #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAML's ResourceDictionary has a custom implementation of `IMap` that returns `E_FAIL` and `HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND)` to indicate that the key is not present. Accommodate this nonstandard behavior.
kennykerr
reviewed
Jul 10, 2020
| inline hresult check_hresult_allow_bounds(hresult const result) | ||
| { | ||
| if (result != impl::error_out_of_bounds) | ||
| if (result != impl::error_out_of_bounds && result != impl::error_fail && result != impl::error_file_not_found) |
Collaborator
There was a problem hiding this comment.
Wish there was some way to incentivize the implementations to clean up their act as this isn't sustainable and they're not likely to fix this on their end.
Member
There was a problem hiding this comment.
It's a contract breaking change now if we "fix" the XAML implementation.
kennykerr
approved these changes
Jul 10, 2020
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XAML's ResourceDictionary has a custom implementation of
IMapthat returnsE_FAILandHRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND)to indicate that the key is not present. Accommodate this nonstandard behavior.Fixes #685