Fix few typos in comments #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that only comments are impacted by this change.
kennykerr
reviewed
Apr 6, 2021
test/catch.hpp
Outdated
| // In other words, it returns the Blue part of Bikeshed::Colour::Blue | ||
| StringRef extractInstanceName(StringRef enumInstance) { | ||
| // Find last occurence of ":" | ||
| // Find last occurrence of ":" |
Collaborator
There was a problem hiding this comment.
This file is generated by https://github.com/catchorg/Catch2 - please make the contribution there and then I'll be happy to ingest a new version from that project.
Member
Author
There was a problem hiding this comment.
Pull request is out: catchorg/Catch2#2206
I don't think that it's worth ingesting a new version just for such a small cosmetic change and I definitely won't be offended if you wait for a more valuable payload before making a new ingestion :)
kennykerr
requested changes
Apr 6, 2021
Collaborator
kennykerr
left a comment
kennykerr
left a comment
There was a problem hiding this comment.
Thanks for the fixes! Happy to accept them, but please revert the change to catch.hpp.
Member
Author
Sure, I've just updated the PR accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this change only impacts comments and metadata, not actual code.