Add starts_with and ends_with to hstring #952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
reviewed
Jun 3, 2021
kennykerr
reviewed
Jun 3, 2021
kennykerr
reviewed
Jun 3, 2021
kennykerr
requested changes
Jun 3, 2021
Collaborator
kennykerr
left a comment
kennykerr
left a comment
There was a problem hiding this comment.
Looking good, just a few comments. Please add a basic test for these methods.
Collaborator
|
Reminder, we need some basic tests to complete this PR. You can just add a simple test to the |
kennykerr
reviewed
Jun 21, 2021
|
|
||
| TEST_CASE("hstring") | ||
| { | ||
| winrt::hstring text = L"C++/WinRT rocks!"; |
kennykerr
reviewed
Jun 21, 2021
kennykerr
approved these changes
Jun 22, 2021
Collaborator
|
All good - the CI build unfortunately won't build remote branches but I've merged and run the internal build and all is green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #907. Adds start_with and ends_with members similar to std::basic_string in C++ 20.