From 07be28673e9d4859a62dfabcd295e4f0c722e574 Mon Sep 17 00:00:00 2001 From: Darren Hoehna Date: Wed, 24 Apr 2024 15:39:54 -0700 Subject: [PATCH 1/2] Adding 'Please check the logs' --- src/GitHubExtension/Providers/RepositoryProvider.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/GitHubExtension/Providers/RepositoryProvider.cs b/src/GitHubExtension/Providers/RepositoryProvider.cs index 8b85fa6..5a09bb7 100644 --- a/src/GitHubExtension/Providers/RepositoryProvider.cs +++ b/src/GitHubExtension/Providers/RepositoryProvider.cs @@ -267,12 +267,12 @@ public IAsyncOperation CloneRepositoryAsync(IRepository catch (LibGit2Sharp.LibGit2SharpException libGitTwoException) { Log.Error(libGitTwoException, $"Either no logged in account has access to this repository, or the repository can't be found."); - return new ProviderOperationResult(ProviderOperationStatus.Failure, libGitTwoException, "LibGit2 library threw an exception.", "LibGit2 library threw an exception."); + return new ProviderOperationResult(ProviderOperationStatus.Failure, libGitTwoException, "LibGit2Sharp threw an exception. Please check the logs for more details.", libGitTwoException.Message); } catch (Exception e) { Log.Error(e, "Could not clone the repository."); - return new ProviderOperationResult(ProviderOperationStatus.Failure, e, "Something happened when cloning the repository.", "Something happened when cloning the repository."); + return new ProviderOperationResult(ProviderOperationStatus.Failure, e, "Something happened when cloning the repository. Please check the logs for more details.", e.Message); } return new ProviderOperationResult(ProviderOperationStatus.Success, new ArgumentException("Nothing wrong"), "Nothing wrong", "Nothing wrong"); From 84f7997e0b05b48a0f3643adbcd60289693ec82c Mon Sep 17 00:00:00 2001 From: Darren Hoehna Date: Wed, 24 Apr 2024 15:43:06 -0700 Subject: [PATCH 2/2] SHowing the error on the loading screen --- src/GitHubExtension/Providers/RepositoryProvider.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/GitHubExtension/Providers/RepositoryProvider.cs b/src/GitHubExtension/Providers/RepositoryProvider.cs index 5a09bb7..55d4f9d 100644 --- a/src/GitHubExtension/Providers/RepositoryProvider.cs +++ b/src/GitHubExtension/Providers/RepositoryProvider.cs @@ -267,12 +267,12 @@ public IAsyncOperation CloneRepositoryAsync(IRepository catch (LibGit2Sharp.LibGit2SharpException libGitTwoException) { Log.Error(libGitTwoException, $"Either no logged in account has access to this repository, or the repository can't be found."); - return new ProviderOperationResult(ProviderOperationStatus.Failure, libGitTwoException, "LibGit2Sharp threw an exception. Please check the logs for more details.", libGitTwoException.Message); + return new ProviderOperationResult(ProviderOperationStatus.Failure, libGitTwoException, libGitTwoException.Message, libGitTwoException.Message); } catch (Exception e) { Log.Error(e, "Could not clone the repository."); - return new ProviderOperationResult(ProviderOperationStatus.Failure, e, "Something happened when cloning the repository. Please check the logs for more details.", e.Message); + return new ProviderOperationResult(ProviderOperationStatus.Failure, e, e.Message, e.Message); } return new ProviderOperationResult(ProviderOperationStatus.Success, new ArgumentException("Nothing wrong"), "Nothing wrong", "Nothing wrong");