Libbpf API compatibility #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
requested review from
Alan-Jowett,
saxena-anurag,
poornagmsft and
shankarseal
dthaler
force-pushed
the
libbpf-compat
branch
5 times, most recently
from
5c0645a
to
1c44da5
Compare
Libbpf is incorporated as a submodule just for the header file. As discussed in issue #84, we cannot currently use the implementation since it is very Linux and GCC specific. This PR also fixes a bug where the user-mode API was calling CloseHandle directly instead of Platform::CloseHandle which is needed to make tests work with the mock platform. Addresses #84 Some code will be cleaner once issue #81 is done Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Alan-Jowett
approved these changes
Jul 29, 2021
| // TODO(issue #223): read this mapping from the registry | ||
| switch (type) { | ||
| case BPF_PROG_TYPE_XDP: | ||
| return &EBPF_PROGRAM_TYPE_XDP; |
There was a problem hiding this comment.
EBPF_PROGRAM_TYPE_XDP definition which is present in ebpf_api.h is temporary till Issue #223 is fixed. Once these definitions are removed, how will bpf_prog_type enums be mapped to the program type guids?
There was a problem hiding this comment.
By reading the mapping from the registry, as line 17 says
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
| @@ -166,6 +166,8 @@ TEST_CASE("libbpf map", "[libbpf]") | |||
| REQUIRE(bpf_map__prev(map, object) == nullptr); | |||
| REQUIRE(bpf_map__prev(nullptr, object) == map); | |||
|
|
|||
| const char* name = bpf_map__name(map); | |||
| REQUIRE(name == nullptr); // droppacket.o has no map name. | |||
There was a problem hiding this comment.
Just mentioning: PR for issue #81 will populate map names also from ELF file.
There was a problem hiding this comment.
that will be great. That PR will need to update this line since the test will fail until this line is updated to match.
saxena-anurag
approved these changes
Jul 30, 2021
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
saxena-anurag
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libbpf is incorporated as a submodule just for the header file.
As discussed in issue #84, we cannot currently use the implementation since it is very Linux and GCC specific.
This PR also fixes a bug where the user-mode API was calling
CloseHandle()directly instead ofPlatform::CloseHandle()which is needed to make tests work with the mock platform.Fixes #84 (future changes should be done under API-specific issues)
Some code will be cleaner once issue #81 is done
Signed-off-by: Dave Thaler dthaler@microsoft.com