Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export data-props from @microsoft/fast-components-explorer package #2269

Open
khamudom opened this issue Sep 24, 2019 · 3 comments
Open

Export data-props from @microsoft/fast-components-explorer package #2269

khamudom opened this issue Sep 24, 2019 · 3 comments

Comments

@khamudom
Copy link
Contributor

@khamudom khamudom commented Sep 24, 2019

Move props in fast-dna\packages\fast-component-explorer\app\utilities\configs\data.props.ts
into @microsoft/fast-components-react-msft package

@Manan311

This comment has been minimized.

Copy link

@Manan311 Manan311 commented Nov 16, 2019

Hello,
I can move the data.props.ts. But before I do I just want to confirm I am moving from packages/fast-component-explorer/app/utilities/configs/data.props.ts to packages/fast-components-react-msft/. Is that right?

@chrisdholt

This comment has been minimized.

Copy link
Member

@chrisdholt chrisdholt commented Dec 4, 2019

Adding @janechu - @khamudom can you elaborate on the goal here? Removing as good first issue for now until we get more information.

@khamudom

This comment has been minimized.

Copy link
Contributor Author

@khamudom khamudom commented Dec 4, 2019

Description
The task is to export data.props.ts in fast-component-explorer\app\utilities\configs

Motivation
In the case, an author would want to create a page similar to the component explorer and use the same data interfaces, we should export the data.props.ts file from a common src file.

Proposal
A suggested place, to export, could be in the fast-toolings-react utilities directory.

@khamudom khamudom changed the title Include data-props to @microsoft/fast-components-react-msft package Export data-props from @microsoft/fast-components-explorer package Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.