Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add flag to autosuggest onValueChange event to label when change is from a suggested option #2002

Merged
merged 4 commits into from Jul 24, 2019

Conversation

@scomea
Copy link
Member

commented Jul 23, 2019

Description

Added a flag to Autosuggest's onValueChange event to indicate that the change was due to focus on a suggested option.

Motivation & context

Without something like this page authors are unable to tell whether they should repopulate options as a user navigates the list of options. This allows them to choose not to refresh the options but still react to changes if they desire. This is an optional param so not a breaking change.

#1989

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@scomea scomea requested review from hchokshi and chrisdholt Jul 23, 2019

@scomea scomea requested a review from janechu as a code owner Jul 23, 2019

@janechu janechu changed the title fix: Add flag to autosuggest onValueChange event to label when change is from a suggested option fix: add flag to autosuggest onValueChange event to label when change is from a suggested option Jul 24, 2019

@scomea scomea force-pushed the users/scomea/autosuggest-limit-onchange branch from 85dc48e to 745c63b Jul 24, 2019

@scomea scomea merged commit f468c33 into master Jul 24, 2019

3 checks passed

ci/circleci: build_dependencies Your tests passed on CircleCI!
Details
ci/circleci: test_coverage Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
Details

@scomea scomea deleted the users/scomea/autosuggest-limit-onchange branch Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.