From a7f6959c6984b7b559ac65a9c21dc119020d19e0 Mon Sep 17 00:00:00 2001 From: Jane Chu <7559015+janechu@users.noreply.github.com> Date: Wed, 8 Apr 2026 11:39:32 -0700 Subject: [PATCH] chore(fast-html): rebase performance-metrics fixture onto main, clean up MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Rebase onto main (includes all previous fixtures up to nested-elements). Resolved build-fixtures.js conflict by appending 'performance-metrics'. Squash two commits into one and remove the extra changefile. Remove redundant {{binding}} attrs (willHydrate, didHydrate, hydrationDuration) from entry elements — property names match root state.json keys so they are passed implicitly. Static attrs (needs-hydration, defer-hydration, defer-delay, displayDelay) are preserved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- ...-599a5431-68aa-4a89-843e-6df26cfd6f59.json | 7 + packages/fast-html/scripts/build-fixtures.js | 17 +- .../fixtures/performance-metrics/entry.html | 25 ++ .../fixtures/performance-metrics/index.html | 410 ++++++++---------- .../fixtures/performance-metrics/state.json | 6 + .../performance-metrics/templates.html | 15 + 6 files changed, 239 insertions(+), 241 deletions(-) create mode 100644 change/@microsoft-fast-html-performance-metrics-599a5431-68aa-4a89-843e-6df26cfd6f59.json create mode 100644 packages/fast-html/test/fixtures/performance-metrics/entry.html create mode 100644 packages/fast-html/test/fixtures/performance-metrics/state.json create mode 100644 packages/fast-html/test/fixtures/performance-metrics/templates.html diff --git a/change/@microsoft-fast-html-performance-metrics-599a5431-68aa-4a89-843e-6df26cfd6f59.json b/change/@microsoft-fast-html-performance-metrics-599a5431-68aa-4a89-843e-6df26cfd6f59.json new file mode 100644 index 00000000000..a47f78c365c --- /dev/null +++ b/change/@microsoft-fast-html-performance-metrics-599a5431-68aa-4a89-843e-6df26cfd6f59.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "chore(fast-html): use @microsoft/fast-build to build performance-metrics fixture", + "packageName": "@microsoft/fast-html", + "email": "7559015+janechu@users.noreply.github.com", + "dependentChangeType": "none" +} diff --git a/packages/fast-html/scripts/build-fixtures.js b/packages/fast-html/scripts/build-fixtures.js index ac6e3c6f502..897306f26b8 100644 --- a/packages/fast-html/scripts/build-fixtures.js +++ b/packages/fast-html/scripts/build-fixtures.js @@ -7,7 +7,22 @@ import { fileURLToPath } from "node:url"; // Builds test fixtures using @microsoft/fast-build. Add fixture names here // incrementally as each one is verified to work with the fast-build CLI. -const fixtures = ["attribute", "binding", "event", "ref", "slotted", "when", "repeat", "repeat-event", "children", "host-bindings", "lifecycle-callbacks", "dot-syntax", "nested-elements"]; +const fixtures = [ + "attribute", + "binding", + "event", + "ref", + "slotted", + "when", + "repeat", + "repeat-event", + "children", + "host-bindings", + "lifecycle-callbacks", + "dot-syntax", + "nested-elements", + "performance-metrics", +]; const __dirname = dirname(fileURLToPath(import.meta.url)); const require = createRequire(import.meta.url); diff --git a/packages/fast-html/test/fixtures/performance-metrics/entry.html b/packages/fast-html/test/fixtures/performance-metrics/entry.html new file mode 100644 index 00000000000..f2718110faf --- /dev/null +++ b/packages/fast-html/test/fixtures/performance-metrics/entry.html @@ -0,0 +1,25 @@ + + + + + Performance Metrics Test + + + + + + + + + + + + + + + + + + + + diff --git a/packages/fast-html/test/fixtures/performance-metrics/index.html b/packages/fast-html/test/fixtures/performance-metrics/index.html index a8ada05573a..aade0ea3f91 100644 --- a/packages/fast-html/test/fixtures/performance-metrics/index.html +++ b/packages/fast-html/test/fixtures/performance-metrics/index.html @@ -1,250 +1,180 @@ - + Performance Metrics Test - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + diff --git a/packages/fast-html/test/fixtures/performance-metrics/state.json b/packages/fast-html/test/fixtures/performance-metrics/state.json new file mode 100644 index 00000000000..81c34824fc2 --- /dev/null +++ b/packages/fast-html/test/fixtures/performance-metrics/state.json @@ -0,0 +1,6 @@ +{ + "displayDelay": "0ms", + "willHydrate": "0ms", + "didHydrate": "0ms", + "hydrationDuration": "0ms" +} diff --git a/packages/fast-html/test/fixtures/performance-metrics/templates.html b/packages/fast-html/test/fixtures/performance-metrics/templates.html new file mode 100644 index 00000000000..0184fcf9c99 --- /dev/null +++ b/packages/fast-html/test/fixtures/performance-metrics/templates.html @@ -0,0 +1,15 @@ + + +