This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Remove dependency on git of environment scripts#86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
Create-FhirServerSamplesAuthConfig.ps1andDelete-FhirServerSamplesAuthConfig.ps1deployment scripts assume that the user has git installed on their system. However, there are situations in which git will not be available, e.g. if the user is using git from WSL but runs the deployment scripts from Windows (I personally just ran into this scenario), or if the user downloaded the fhir-server-samples repository from Github manually as opposed to cloning it.This pull request removes the dependency on git by fetching the fhir-server code as a zip file via a HTTP request to Github's code download endpoint (see StackOverflow and Github docs). Besides removing an external dependency, this approach also has the advantage that the scripts now no longer have to fetch the entire git history and instead only fetch the code at a particular commit which in my tests reduced the download size considerably (17 MB for git clone versus 2 MB for the zip file).