Skip to content
This repository has been archived by the owner. It is now read-only.

Remove dependency on git of environment scripts #86

Merged
merged 1 commit into from Jan 28, 2021
Merged

Remove dependency on git of environment scripts #86

merged 1 commit into from Jan 28, 2021

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jul 7, 2020

Currently the Create-FhirServerSamplesAuthConfig.ps1 and Delete-FhirServerSamplesAuthConfig.ps1 deployment scripts assume that the user has git installed on their system. However, there are situations in which git will not be available, e.g. if the user is using git from WSL but runs the deployment scripts from Windows (I personally just ran into this scenario), or if the user downloaded the fhir-server-samples repository from Github manually as opposed to cloning it.

This pull request removes the dependency on git by fetching the fhir-server code as a zip file via a HTTP request to Github's code download endpoint (see StackOverflow and Github docs). Besides removing an external dependency, this approach also has the advantage that the scripts now no longer have to fetch the entire git history and instead only fetch the code at a particular commit which in my tests reduced the download size considerably (17 MB for git clone versus 2 MB for the zip file).

@ginalee-dotcom ginalee-dotcom merged commit 48f4cd1 into microsoft:master Jan 28, 2021
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants