Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"@rnx-kit/eslint-plugin" is breaking lint pipelines #20774

Closed
Hotell opened this issue Nov 25, 2021 · 2 comments · Fixed by #20781
Closed

"@rnx-kit/eslint-plugin" is breaking lint pipelines #20774

Hotell opened this issue Nov 25, 2021 · 2 comments · Fixed by #20781
Assignees
@khmakoto
Labels
Area: Build System dependencies Pull requests that update a dependency file Needs: Triage 🔍 Priority 1: High Status: Fixed Fixed in some PR Type: Bug 🐛
Projects
V-Build - @microsoft/fluentui-react-b...

Comments

@Hotell
Copy link
Contributor

Hotell commented Nov 25, 2021

Describe the issue:

yarn workspace nx-workspace-tools lint

throws error

2021-11-25 at 10 25

Caused by https://github.com/microsoft/fluentui/pull/20665/files#diff-691525462f8b4cac47c3c2e0e2668606f539ed0b3f62f8f6b79dffe7ef38bd9dR15

  • this is caused as that plugin ships non transpiled code -> optional chaining operator
@Hotell Hotell added this to Backlog in V-Build - @microsoft/fluentui-react-build via automation Nov 25, 2021
@Hotell
Copy link
Contributor Author

Hotell commented Nov 25, 2021

this will pass on CI, because we already bumped to node 14 - https://uifabric.visualstudio.com/fabricpublic/_build/results?buildId=227889&view=logs&j=258ec178-2d8b-5611-7b9b-60c5c95dae55&t=36b30cb7-e32b-56ae-15b9-bd436e45f939

curios when did this happened @ling1726 @ecraig12345 ?

@ling1726
Copy link
Member

@Hotell it seems node was bumped in #20732

@andrefcdias andrefcdias mentioned this issue Nov 25, 2021
Merged
2 tasks
V-Build - @microsoft/fluentui-react-build automation moved this from Backlog to Done Nov 25, 2021
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Nov 25, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Dec 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@khmakoto khmakoto

Labels
Area: Build System dependencies Pull requests that update a dependency file Needs: Triage 🔍 Priority 1: High Status: Fixed Fixed in some PR Type: Bug 🐛
Projects
No open projects
V-Build - @microsoft/fluentui-react-b...
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Revert to node 12
4 participants
@Hotell @khmakoto @ling1726 @msft-fluent-ui-bot