Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Removing overflow items without unmounting an overflow item component #29509

Closed
2 tasks done
lekoaf opened this issue Oct 12, 2023 · 5 comments · Fixed by #31340
Closed
2 tasks done

[Feature]: Removing overflow items without unmounting an overflow item component #29509

lekoaf opened this issue Oct 12, 2023 · 5 comments · Fixed by #31340

Comments

@lekoaf
Copy link
Contributor

lekoaf commented Oct 12, 2023

Library

React Components / v9 (@fluentui/react-components)

System Info

System:
    OS: Linux 6.0 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
    Memory: 16.86 GB / 31.04 GB
    Container: Yes
    Shell: 5.8.1 - /bin/zsh
Browsers:
    Chrome: 116.0.5845.140

Are you reporting Accessibility issue?

no

Reproduction

https://codesandbox.io/p/sandbox/youthful-aj-92tq3t

Bug Description

Actual Behavior

When removing items from an overflow menu, the menu bugs out with an empty menu.

If I had only used the buttons to remove the items, it works.
overflow_button

But when using the menu, it bugs out.
overflow

Expected Behavior

Overflow menu should dissapear when enough items have been removed.

Logs

No response

Requested priority

High

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@lekoaf
Copy link
Contributor Author

lekoaf commented Oct 13, 2023

Are you willing to submit a PR to fix? no

I could be willing, but I don't know where the issue is. Haven't dived in to the Fluent source code.

ling1726 added a commit to ling1726/fluentui that referenced this issue Oct 17, 2023
Updates all instance of ResizeObserver in react-components to be created
from the correct window global. The enforcement is not in the scope of
this PR and is already in progress in microsoft#28887.

Fixes microsoft#29509
@lekoaf
Copy link
Contributor Author

lekoaf commented Oct 19, 2023

The "Status: In PR" label doesn't seem to be correct. I think @ling1726 accidently mentioned the wrong issue in his PR.

@ling1726
Copy link
Member

The design of the overflow library never took into account removal of items from the menu, only from the actual overflow set. The reason being that, the requirements were mainly driven by a toolbar being overflown.

This is a valid feature request and we should see how to prioritize this

@ling1726 ling1726 changed the title [Bug]: Removing items from overflow menu causes bug [Feature]: Removing overflow items without unmounting an overflow item component Oct 19, 2023
@lekoaf
Copy link
Contributor Author

lekoaf commented Oct 20, 2023

@ling1726 @miroslavstastny, this issue shouldn't be closed. It was closed because it was accidently mentioned in a PR.

@ling1726 ling1726 reopened this Oct 20, 2023

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants