-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Removing overflow items without unmounting an overflow item component #29509
Comments
I could be willing, but I don't know where the issue is. Haven't dived in to the Fluent source code. |
Updates all instance of ResizeObserver in react-components to be created from the correct window global. The enforcement is not in the scope of this PR and is already in progress in microsoft#28887. Fixes microsoft#29509
The "Status: In PR" label doesn't seem to be correct. I think @ling1726 accidently mentioned the wrong issue in his PR. |
The design of the overflow library never took into account removal of items from the menu, only from the actual overflow set. The reason being that, the requirements were mainly driven by a toolbar being overflown. This is a valid feature request and we should see how to prioritize this |
@ling1726 @miroslavstastny, this issue shouldn't be closed. It was closed because it was accidently mentioned in a PR. |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Library
React Components / v9 (@fluentui/react-components)
System Info
Are you reporting Accessibility issue?
no
Reproduction
https://codesandbox.io/p/sandbox/youthful-aj-92tq3t
Bug Description
Actual Behavior
When removing items from an overflow menu, the menu bugs out with an empty menu.
If I had only used the buttons to remove the items, it works.
But when using the menu, it bugs out.
Expected Behavior
Overflow menu should dissapear when enough items have been removed.
Logs
No response
Requested priority
High
Products/sites affected
No response
Are you willing to submit a PR to fix?
no
Validations
The text was updated successfully, but these errors were encountered: