Skip to content

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Feb 22, 2017

Pull request checklist

  • Addresses an existing issue: #0000
  • Include a change request file if publishing
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Description of changes

This pull request moves the initials logic to a utility, thus addressing one of the comments that @dzearing left on #760.

Focus areas to test

This change is just a refactor. No new functionality added. Everything is covered by existing unit tests.

c-w added 2 commits February 22, 2017 14:56
This will enable easy unit testing, re-use, etc. going forward.
@msftclas
Copy link

Hi @c-w, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@c-w
Copy link
Contributor Author

c-w commented Feb 23, 2017

Putting this on the radar of @cliffkoh.

Copy link
Contributor

@cliffkoh cliffkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@c-w
Copy link
Contributor Author

c-w commented Feb 24, 2017

Pinging @cliffkoh to hit the merge button before the master branch advances again.

@cliffkoh cliffkoh merged commit 2443a37 into microsoft:master Feb 24, 2017
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants