Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move initials logic out of Persona component and into utility #1090

merged 5 commits into from
Feb 24, 2017


Copy link

@c-w c-w commented Feb 22, 2017

Pull request checklist

  • Addresses an existing issue: #0000
  • Include a change request file if publishing
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Description of changes

This pull request moves the initials logic to a utility, thus addressing one of the comments that @dzearing left on #760.

Focus areas to test

This change is just a refactor. No new functionality added. Everything is covered by existing unit tests.

Copy link

Hi @c-w, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing!


Copy link
Contributor Author

c-w commented Feb 23, 2017

Putting this on the radar of @cliffkoh.

Copy link

@cliffkoh cliffkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Copy link
Contributor Author

c-w commented Feb 24, 2017

Pinging @cliffkoh to hit the merge button before the master branch advances again.

@cliffkoh cliffkoh merged commit 2443a37 into microsoft:master Feb 24, 2017
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants