Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Persona color swatches declaration #1157

Merged
merged 4 commits into from Mar 1, 2017
Merged

Fix typo in Persona color swatches declaration #1157

merged 4 commits into from Mar 1, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Mar 1, 2017

Pull request checklist

  • Addresses an existing issue: #0000
  • Include a change request file if publishing
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Description of changes

Previously, there were two entries for lightPink and no entry for pink meaning that we're disproportionately more likely to create lightPink Persona bubbles and it's impossible to create pink Persona bubbles.

Focus areas to test

Just a constant change, no need for in-depth testing.

Previously, there were two entries for lightPink and no entry for pink
meaning that we're disproportionately more likely to create lightPink
Persona bubbles and it's impossible to create pink Persona bubbles.
@msftclas
Copy link

@msftclas msftclas commented Mar 1, 2017

@c-w,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@c-w
Copy link
Contributor Author

@c-w c-w commented Mar 1, 2017

Putting this onto your radar, @cliffkoh, since you reviewed changes to the Persona component previously.

Copy link
Member

@micahgodbolt micahgodbolt left a comment

Yup, nice catch.

@c-w
Copy link
Contributor Author

@c-w c-w commented Mar 1, 2017

Pinging @micahgodbolt to hit the merge button before master advances again.

@micahgodbolt micahgodbolt merged commit b9778b2 into microsoft:master Mar 1, 2017
1 check passed
@cliffkoh
Copy link
Contributor

@cliffkoh cliffkoh commented Mar 1, 2017

@c-w This is great, thanks for the patch.

aleksandrjPersonal pushed a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this issue Mar 10, 2017
Previously, there were two entries for lightPink and no entry for pink
meaning that we're disproportionately more likely to create lightPink
Persona bubbles and it's impossible to create pink Persona bubbles.
aleksandrjPersonal pushed a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this issue Mar 10, 2017
Previously, there were two entries for lightPink and no entry for pink
meaning that we're disproportionately more likely to create lightPink
Persona bubbles and it's impossible to create pink Persona bubbles.
aleksandrjPersonal pushed a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this issue Mar 10, 2017
Previously, there were two entries for lightPink and no entry for pink
meaning that we're disproportionately more likely to create lightPink
Persona bubbles and it's impossible to create pink Persona bubbles.
aleksandrjPersonal pushed a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this issue Mar 10, 2017
Previously, there were two entries for lightPink and no entry for pink
meaning that we're disproportionately more likely to create lightPink
Persona bubbles and it's impossible to create pink Persona bubbles.
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants