Fix typo in Persona color swatches declaration #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there were two entries for lightPink and no entry for pink meaning that we're disproportionately more likely to create lightPink Persona bubbles and it's impossible to create pink Persona bubbles.
|
@c-w, |
|
Putting this onto your radar, @cliffkoh, since you reviewed changes to the Persona component previously. |
|
Pinging @micahgodbolt to hit the merge button before master advances again. |
|
@c-w This is great, thanks for the patch. |
aleksandrjPersonal
pushed a commit
to aleksandrjPersonal/office-ui-fabric-react
that referenced
this pull request
Mar 10, 2017
Previously, there were two entries for lightPink and no entry for pink meaning that we're disproportionately more likely to create lightPink Persona bubbles and it's impossible to create pink Persona bubbles.
aleksandrjPersonal
pushed a commit
to aleksandrjPersonal/office-ui-fabric-react
that referenced
this pull request
Mar 10, 2017
Previously, there were two entries for lightPink and no entry for pink meaning that we're disproportionately more likely to create lightPink Persona bubbles and it's impossible to create pink Persona bubbles.
aleksandrjPersonal
pushed a commit
to aleksandrjPersonal/office-ui-fabric-react
that referenced
this pull request
Mar 10, 2017
Previously, there were two entries for lightPink and no entry for pink meaning that we're disproportionately more likely to create lightPink Persona bubbles and it's impossible to create pink Persona bubbles.
aleksandrjPersonal
pushed a commit
to aleksandrjPersonal/office-ui-fabric-react
that referenced
this pull request
Mar 10, 2017
Previously, there were two entries for lightPink and no entry for pink meaning that we're disproportionately more likely to create lightPink Persona bubbles and it's impossible to create pink Persona bubbles.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
Previously, there were two entries for lightPink and no entry for pink meaning that we're disproportionately more likely to create lightPink Persona bubbles and it's impossible to create pink Persona bubbles.
Focus areas to test
Just a constant change, no need for in-depth testing.