Addressing PR feedback for SearchBox and VerticalDivider examples #12563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix/example-updates # Conflicts: # packages/office-ui-fabric-react/src/components/Divider/examples/VerticalDivider.Custom.Example.tsx # packages/office-ui-fabric-react/src/components/SearchBox/examples/SearchBox.CustomIcon.Example.tsx # packages/office-ui-fabric-react/src/components/SearchBox/examples/SearchBox.Disabled.Example.tsx # packages/office-ui-fabric-react/src/components/SearchBox/examples/SearchBox.FullSize.Example.tsx # packages/office-ui-fabric-react/src/components/SearchBox/examples/SearchBox.Small.Example.tsx # packages/office-ui-fabric-react/src/components/SearchBox/examples/SearchBox.Underlined.Example.tsx
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 18799a4d2fc3364e3323bfb9d80b55894e641369 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
dzearing
approved these changes
Apr 7, 2020
|
🎉 Handy links: |
ecraig12345
reviewed
Apr 7, 2020
There was a problem hiding this comment.
Thanks for doing this! A couple more things (plus the file comment below):
At least going forward, please include a React.FunctionComponent type declaration for each example, e.g.:
export const VerticalDividerCustomExample: React.FunctionComponent = () => {
And see this comment #12519 (comment)
| onChange={() => console.log('onChange called')} | ||
| /> | ||
| <Stack tokens={stackTokens}> | ||
| <SearchBox placeholder="Search" onSearch={newValue => console.log('value is ' + newValue)} /> |
There was a problem hiding this comment.
This should go in a constant at the top of the file too (and then you can remove the tslint-disable):
const onSearch = newValue => console.log('value is ' + newValue)
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
…crosoft#12563) * Examples update * Change files * Simplified SearchBox return statement and brackets * Snapshot update for VerticalDividerBasicExample * Optimizing SearchBox and VerticalDivider examples component render * Change files * Deleting extra change file. * Change files * Added change file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Addressing feedback from #12519
SearchBox.VerticalDividerto be called outside of component.Focus areas to test
The example pages for
SearchBoxandVerticalDivider.Microsoft Reviewers: Open in CodeFlow